Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] fix join metric field selection bugs #56044

Merged
merged 3 commits into from
Jan 28, 2020
Merged

[Maps] fix join metric field selection bugs #56044

merged 3 commits into from
Jan 28, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 27, 2020 •
edited
Loading

#48961 introduced unique count metric aggregation. Unique count metric works on more fields than just number. This introduced some logic to show all fields in the metrics field select when using unique count.

The original PR failed to account for two edge cases

  1. field is not aggregatable. This check was not needed before since all number fields store doc_values and are thus aggregatable. Now an explicit check is needed.

Screen Shot 2020-01-27 at 1 24 50 PM

  1. Clear the field selection when switching between unique count aggregation and other aggregation types when field is not a number.

@nreese nreese requested a review from a team as a code owner January 27, 2020 18:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from nickpeihl January 27, 2020 18:39
@nreese nreese changed the title lint fixes [Maps] fix join metric field selection bugs Jan 27, 2020
nickpeihl
nickpeihl approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested in Chrome and code review.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 1488aa9 into elastic:master Jan 28, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jan 28, 2020
@nreese
[Maps] fix join metric field selection bugs (elastic#56044)
d4d2f51 
* lint fixes

* move aggregation check to MEtricEditor

* fix functional test, handle case where fields are not loaded
@nreese nreese mentioned this pull request Jan 28, 2020
Merged
nreese added a commit to nreese/kibana that referenced this pull request Jan 28, 2020
@nreese
[Maps] fix join metric field selection bugs (elastic#56044)
d0f0002 
* lint fixes

* move aggregation check to MEtricEditor

* fix functional test, handle case where fields are not loaded
@nreese nreese mentioned this pull request Jan 28, 2020
Merged
nreese added a commit that referenced this pull request Jan 28, 2020
@nreese
[Maps] fix join metric field selection bugs (#56044) (#56088)
11b7ad8 
* lint fixes

* move aggregation check to MEtricEditor

* fix functional test, handle case where fields are not loaded
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 28, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into np/console/mo…
5f76f38 
…ve-out-legacy

* 'master' of github.com:elastic/kibana: (187 commits)
  [ML] Reseting categorization validation if category field is cleared (elastic#56029)
  [SIEM] Fields browser readable (elastic#56000)
  [docs] Remove unused callout (elastic#56032)
  Refactor saved object management registry usage (elastic#54155)
  [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090)
  Fix failing snapshot artifact tests when using env var (elastic#56063)
  Fix Github PR comment formatting (elastic#56078)
  [Maps] fix join metric field selection bugs (elastic#56044)
  Create a new menu for observability links (elastic#54847)
  [SIEM] [Detection Engine] Fixes histogram intervals  (elastic#55969)
  make test less flaky by retrying if list is re-rendered (elastic#55949)
  Remove matrix build support (elastic#54202)
  Add animation to service map layout (elastic#56042)
  [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050)
  [Uptime] Simplify snapshot max to Infinity (elastic#55931)
  [Uptime] Reintroduce a column for url (elastic#55451)
  Cleanup action task params objects after successful execution (elastic#55227)
  [CI] Retry flaky tests (elastic#53961)
  Expose NP FieldFormats service to server side (elastic#55419)
  [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel.tsx
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/context.tsx
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/index.ts
#	src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/split_panel.test.tsx
#	src/legacy/ui/public/vis/editors/default/default_editor.tsx
#	src/plugins/console/public/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/plugins/console/public/application/components/split_panel/components/resizer.tsx
#	src/plugins/console/public/application/components/split_panel/containers/panel.tsx
#	src/plugins/console/public/application/components/split_panel/containers/panel_container.tsx
#	src/plugins/console/public/application/components/split_panel/context.tsx
#	src/plugins/console/public/application/components/split_panel/index.ts
#	src/plugins/console/public/application/components/split_panel/registry.ts
#	src/plugins/console/public/application/components/split_panel/split_panel.test.tsx
#	src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap
#	src/plugins/kibana_react/public/split_panel/containers/panel.tsx
#	src/plugins/kibana_react/public/split_panel/context.tsx
#	src/plugins/kibana_react/public/split_panel/index.ts
#	src/plugins/kibana_react/public/split_panel/split_panel.test.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 28, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
c011aa9 
* master: (77 commits)
  [ML] Reseting categorization validation if category field is cleared (elastic#56029)
  [SIEM] Fields browser readable (elastic#56000)
  [docs] Remove unused callout (elastic#56032)
  Refactor saved object management registry usage (elastic#54155)
  [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090)
  Fix failing snapshot artifact tests when using env var (elastic#56063)
  Fix Github PR comment formatting (elastic#56078)
  [Maps] fix join metric field selection bugs (elastic#56044)
  Create a new menu for observability links (elastic#54847)
  [SIEM] [Detection Engine] Fixes histogram intervals  (elastic#55969)
  make test less flaky by retrying if list is re-rendered (elastic#55949)
  Remove matrix build support (elastic#54202)
  Add animation to service map layout (elastic#56042)
  [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050)
  [Uptime] Simplify snapshot max to Infinity (elastic#55931)
  [Uptime] Reintroduce a column for url (elastic#55451)
  Cleanup action task params objects after successful execution (elastic#55227)
  [CI] Retry flaky tests (elastic#53961)
  Expose NP FieldFormats service to server side (elastic#55419)
  [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772)
  ...
nreese added a commit that referenced this pull request Jan 28, 2020
@nreese @elasticmachine
[Maps] fix join metric field selection bugs (#56044) (#56089)
a61e344 
* lint fixes

* move aggregation check to MEtricEditor

* fix functional test, handle case where fields are not loaded

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @nickpeihl