[Discover] Inline angular directives only used in this plugin #56119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
changed the title
kertal
added
Feature:NP Migration
Feature:Discover
…-28-discover_inline_static_code_deps
24 tasks
kertal
commented
Jan 30, 2020
| @import 'histogram'; | ||
| @import './collapsible_sidebar/index'; |
There was a problem hiding this comment.
dear @elastic/kibana-design, no new SCSS inside, just change of path and imports
There was a problem hiding this comment.
I just reviewed the SCSS files that were moved to a new directory and LGTM!
|
Jenkins, test this - seems to be a unrelated error |
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jan 31, 2020
flash1293
reviewed
Jan 31, 2020
| @@ -19,8 +19,8 @@ | |||
| import React from 'react'; | |||
| import classNames from 'classnames'; | |||
| // @ts-ignore | |||
| import { shortenDottedString } from '../../../../core_plugins/kibana/common/utils/shorten_dotted_string'; | |||
| import { FieldIcon } from '../../../../../../src/plugins/kibana_react/public'; | |||
| import { shortenDottedString } from '../../../../../../common/utils/shorten_dotted_string'; | |||
There was a problem hiding this comment.
It seems like shorten_dotted_string is also available from the data plugin src/plugins/data/common/utils/shorten_dotted_string.ts
There was a problem hiding this comment.
Thanks for that hint! Done! Goodbye to another @ts-ignore, another brick in our old-kibana-wall. think we could now start to plan a museum of old code fragments. before everybody forgets.
…-28-discover_inline_static_code_deps
…of github.com:kertal/kibana into kertal-pr-2020-01-28-discover_inline_static_code_deps
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
elizabetdev
approved these changes
Feb 4, 2020
|
thx @miukimiu, @flash1293 for the reviews, time to merge! |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Feb 4, 2020
…c#56119) * Migrate field_name directive * Migrate collapsible_sidebar directive * Fix FieldName import at table_row.tsx * Migrate css_truncate directive * Migrate fixed_scroll & debounce directives * Migrate render_complete directive * Fix css_truncate test * Use shortenDottedString in the TypesScript version
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2020
* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...
kertal
added a commit
that referenced
this pull request
Feb 4, 2020
#56744) * Migrate field_name directive * Migrate collapsible_sidebar directive * Fix FieldName import at table_row.tsx * Migrate css_truncate directive * Migrate fixed_scroll & debounce directives * Migrate render_complete directive * Fix css_truncate test * Use shortenDottedString in the TypesScript version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following imports are only used by discover and are inlined into the discover plugin by this PR
ui/directives/field_name/field_nameui/directives/listen/listen- it's also used by timelion and mapsui/collapsible_sidebar/collapsible_sidebarui/directives/css_truncateui/fixed_scrollui/directives/debounce/debounceui/render_complete/directivePart of #50670
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately