Add getServerInfo API to http setup contract
#56636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
commented
Feb 3, 2020
Comment on lines
+126
to
132
| getServerInfo: () => ({ | ||
| name: config.name, | ||
| host: config.host, | ||
| port: config.port, | ||
| protocol: this.server!.info.protocol, | ||
| }), | ||
| isTlsEnabled: config.ssl.enabled, |
There was a problem hiding this comment.
Now that we got this getServerInfo API, should I move the isTlsEnabled info in the HttpServerInfo type and remove the direct access from the setup contract?
There was a problem hiding this comment.
Ok, I'll do it in a separate PR later this week
pgayvallet
added
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
joshdover
approved these changes
Feb 3, 2020
|
|
||
| expect(getServerInfo().protocol).toEqual('https'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Test for when protocol is socket?
There was a problem hiding this comment.
I will be honest, I have no idea how to configure the server to get a socket protocol (only copied the possible values from the HAPI's config.protocol)
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Feb 4, 2020
* add getServerInfo http setup api * update generated doc
pgayvallet
added a commit
that referenced
this pull request
Feb 4, 2020
* add getServerInfo http setup api * update generated doc
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2020
* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #56231
Adds a
getServerInfoAPI tohttpServer'ssetupcontract returning basic server infos such asport,hostnameandprotocol.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers