Deprecate split chart option for tile map visualization #6001
Conversation
|
tests are failing |
|
This also needs to be rebased on master or have master merged into it. |
|
jenkins, test it. |
|
This pr is failing because of a bug in grunt:esvm. See here. |
|
jenkins, test it |
|
jenkins, test it |
|
That is to say, you won't be removing any code in this pull, you'll just be adding a new parameter to the schema, for example here: https://github.com/elastic/kibana/blob/master/src/plugins/kbn_vislib_vis_types/public/tile_map.js#L123 You might add to the |
|
Perhaps we should also start showing a deprecation warning when people are using existing split charts? We could add a hideSplitChartWarning config value or something to let people disable the warning since it would be user facing, but this way they'd see the warning at least once and would know that it could potentially be removed in future versions. |
|
@epixa jinx 😄 |
|
jenkins, test it |
|
@rashidkpc ok, can you check this out now. |
| <div ng-if="agg.schema.deprecate" class="form-group"> | ||
| <p class="vis-editor-agg-error"> | ||
| "{{ agg.schema.title }}" has been deprecated. |
There was a problem hiding this comment.
This is makes it sound like splitting of all charts has been deprecated. Maybe it would make sense to be able to provide a deprecation notice in src/plugins/kbn_vislib_vis_types/public/tile_map.js
|
Aside from being able to set a custom deprecation notice, this looks good. |
|
@rashidkpc I added a custom deprecation message option. Passing it back to you. |
|
LGTM |
epixa
changed the title
|
Can one of the admins verify this patch? |
Closes #5728.
The current behavior for splitting charts in the tile map visualization is broken. When there are multiple tile maps in one visualization, a user can drag the tiles of one map over another. This is undesired behavior and until a solution can be found to prevent this, the option for splitting charts should be removed. The gif below shows this broken behavior in action.