Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

Fix ES config overrides #32

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Mar 2, 2016

Still need to create elasticsearch.json for overrides of default ES options to work. This is causing builds to fail because grunt esvm:test is running ES on port 9200 instead of 9210 like it should.

http://build-eu-00.elastic.co/job/kibana_core_pr/2337/console

@epixa
Copy link

epixa commented Mar 3, 2016

@Bargs Can we revert the dependency version in kibana in the meantime, or is this a must-have at the moment?

simianhacker added a commit that referenced this pull request Mar 3, 2016
@simianhacker simianhacker merged commit 92b2675 into elastic:master Mar 3, 2016
@Bargs
Copy link
Contributor Author

Bargs commented Mar 3, 2016

@epixa My PR to update the dependency in Kibana hasn't been merged, this issue is that grunt-esvm has it's own dependency on libesvm listed as ^3.4.0, so a fresh npm install is pulling in the most recent version. Looks like @simianhacker just merged this and published a new version to NPM, so that should fix the tests without changing anything in Kibana.

@epixa
Copy link

epixa commented Mar 3, 2016

@Bargs Hmm... I reran jobs that seemed to be blocked on this, but they're still erroring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants