[SearchProfiler] Minor fixes #60919
Merged
[SearchProfiler] Minor fixes #60919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Thanks for fixing these bugs @jloleysens! Tested locally and everything LGTM. Left one comment about possibly removing a console statement.
x-pack/plugins/searchprofiler/public/application/components/profile_tree/profile_tree.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 24, 2020
* Fix auto-expanding of shards in profile tree * Fix bad error message for ES errors that don't have line numbers * Add error message for bad profile data * Fix type and test issues and rename __test__ folder to __jest__ * ! 👉🏻.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 24, 2020
* master: Updating our direct usage of https-proxy-agent to 5.0.0 (elastic#58296) allow users to unset the throttle of an alert (elastic#60964) [Lens] Fix bug in metric config panel (elastic#60982) [SearchProfiler] Minor fixes (elastic#60919) [ML] Renaming ML setup and start contracts (elastic#60980) introduce StartServicesAccessor type for `CoreSetup.getStartServices` (elastic#60748) [SIEM][Detection Engine] Add rule's notification alert type (elastic#60832) [APM] Re-revert "Collect telemetry about data/API performance" (elastic#61030) [NP] Graph: get rid of saved objects class wrapper (elastic#59917) [EPM] merge duplicate fields when creating index patterns (elastic#60957) [Uptime] Ml detection of duration anomalies (elastic#59785) [Alerting] removes unimplemented buttons from Alert Details page (elastic#60934) [skip-ci] Fix CODEOWNERS paths for the Pulse team (elastic#60944) [APM] Threshold alerts (elastic#59566) [ML] Add support for percentiles aggregation to Transform wizard (elastic#60763) Cahgen save object duplicate message (elastic#60901)
jloleysens
added a commit
that referenced
this pull request
Mar 24, 2020
* Fix auto-expanding of shards in profile tree * Fix bad error message for ES errors that don't have line numbers * Add error message for bad profile data * Fix type and test issues and rename __test__ folder to __jest__ * ! 👉🏻. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After running through the test cases the a regression was detected with the auto-expanding behaviour (shards should auto-expand up to operations that have had >= 20% of time spent in servicing the search or aggregation).
Other fixes/improvements:
{ "profile": { "shards": [{}] } }). On master there was no notification.After fix:
Checklist
Delete any items that are not applicable to this PR.