Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] merge duplicate fields when creating index patterns #60957

Merged
merged 3 commits into from
Mar 24, 2020
Merged

[EPM] merge duplicate fields when creating index patterns #60957

merged 3 commits into from
Mar 24, 2020

Conversation

neptunian
Copy link
Contributor

  • fix bug where an already installed packaged was installed twice through endpoint
  • fix bug where datasets were including wrong fields because of incorrect comparison using includes() (eg network_summary includes the network dataset fields)
  • merge duplicate fields (same name and type) with existing field taking precedence

@neptunian neptunian added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 23, 2020
@neptunian neptunian requested a review from a team March 23, 2020 18:20
nchaulet
nchaulet approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Only one suggestion about tests why not using more realistic scenario and field name? In my opinion a having more real life scenario allow an easier way to understand what a feature|function is doing and why it's needed

@neptunian
Copy link
Contributor Author

@nchaulet Personally, I find it easier to understand to use names like a.b.c or 1.2.3 because it helps me to focus on understanding the functionality and not any particular use case, but I can see where it could be misleading or confusing. I will think about that.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit 3cb7053 into elastic:master Mar 24, 2020
@neptunian neptunian mentioned this pull request Mar 24, 2020
Merged
@neptunian neptunian deleted the 56306-handle-dupes-index-patterns branch March 24, 2020 12:03
neptunian added a commit that referenced this pull request Mar 24, 2020
@neptunian
[EPM] merge duplicate fields when creating index patterns (#60957) (#…
51c9b97 
…61052)

* fix bug where an already installed packaged was installed twice through endpoint

* fix bug where dataset like network and network_summary were not differentiated

* handle duplicate fields by merging fields of the same type
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 24, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
bec4553 
* master:
  Updating our direct usage of https-proxy-agent to 5.0.0 (elastic#58296)
  allow users to unset the throttle of an alert (elastic#60964)
  [Lens] Fix bug in metric config panel (elastic#60982)
  [SearchProfiler] Minor fixes (elastic#60919)
  [ML] Renaming ML setup and start contracts (elastic#60980)
  introduce StartServicesAccessor type for `CoreSetup.getStartServices` (elastic#60748)
  [SIEM][Detection Engine] Add rule's notification alert type (elastic#60832)
  [APM] Re-revert "Collect telemetry about data/API performance" (elastic#61030)
  [NP] Graph: get rid of saved objects class wrapper (elastic#59917)
  [EPM] merge duplicate fields when creating index patterns (elastic#60957)
  [Uptime] Ml detection of duration anomalies (elastic#59785)
  [Alerting] removes unimplemented buttons from Alert Details page (elastic#60934)
  [skip-ci] Fix CODEOWNERS paths for the Pulse team (elastic#60944)
  [APM] Threshold alerts (elastic#59566)
  [ML] Add support for percentiles aggregation to Transform wizard (elastic#60763)
  Cahgen save object duplicate message (elastic#60901)
This was referenced Mar 25, 2020
Closed
Closed
@jen-huang jen-huang added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neptunian @kibanamachine @elasticmachine @nchaulet @jen-huang