Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional API test - disable mml value check #61446

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 26, 2020

Summary

This PR re-activates the model memory estimation endpoint test and disabled the response value check.

Details

There are more changes planned for the model memory calculation, which may change the estimated value in the response and thus breaking the tests again. We decided to wait for the planned changes to go in, before we re-enable the value checks again.

Closes #61400

@pheyos pheyos added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.8.0 labels Mar 26, 2020
@pheyos pheyos self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos changed the title [ML] Functional API test - adjust expected model memory limit [ML] Functional API test - disable mml value check Mar 26, 2020
@pheyos pheyos requested a review from peteharverson March 26, 2020 13:11
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 2371ee5 into elastic:master Mar 26, 2020
@pheyos pheyos deleted the fix_mml_api_test branch March 26, 2020 15:11
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 26, 2020
This PR re-activates the model memory estimation endpoint test and disabled the response value check.
pheyos added a commit that referenced this pull request Mar 26, 2020
This PR re-activates the model memory estimation endpoint test and disabled the response value check.
@pheyos pheyos restored the fix_mml_api_test branch April 1, 2020 09:08
@pheyos pheyos deleted the fix_mml_api_test branch April 1, 2020 09:14
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Apr 1, 2020
This PR re-activates the model memory estimation endpoint test and disabled the response value check.
tylersmalley pushed a commit that referenced this pull request Apr 1, 2020
This PR re-activates the model memory estimation endpoint test and disabled the response value check.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration v7.8.0 v8.0.0
Projects
None yet
5 participants