Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional API test - disable mml value check #61446

Merged
merged 2 commits into from
Mar 26, 2020
Merged

[ML] Functional API test - disable mml value check #61446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869cff5
[ML] Functional API test - adjust expected model memory limit
pheyos Mar 26, 2020
5230605
Disable mml value check
pheyos Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions x-pack/test/api_integration/apis/ml/calculate_model_memory_limit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
* you may not use this file except in compliance with the Elastic License.
*/

import expect from '@kbn/expect';

import { FtrProviderContext } from '../../ftr_provider_context';
import { USER } from '../../../functional/services/machine_learning/security_common';

Expand Down Expand Up @@ -142,13 +140,12 @@ export default ({ getService }: FtrProviderContext) => {
},
expected: {
responseCode: 200,
responseBody: { estimatedModelMemoryLimit: '12MB', modelMemoryLimit: '12MB' },
responseBody: { estimatedModelMemoryLimit: '11MB', modelMemoryLimit: '11MB' },
},
},
];

// failing test, see https://github.com/elastic/kibana/issues/61400
describe.skip('calculate model memory limit', function() {
describe('calculate model memory limit', function() {
before(async () => {
await esArchiver.load('ml/ecommerce');
});
Expand All @@ -159,14 +156,16 @@ export default ({ getService }: FtrProviderContext) => {

for (const testData of testDataList) {
it(`calculates the model memory limit ${testData.testTitleSuffix}`, async () => {
const { body } = await supertest
await supertest
.post('/api/ml/validate/calculate_model_memory_limit')
.auth(testData.user, mlSecurity.getPasswordForUser(testData.user))
.set(COMMON_HEADERS)
.send(testData.requestBody)
.expect(testData.expected.responseCode);

expect(body).to.eql(testData.expected.responseBody);
// More backend changes to the model memory calculation are planned.
// This value check will be re-enabled when the final batch of updates is in.
// expect(body).to.eql(testData.expected.responseBody);
});
}
});
Expand Down