[CI] Add pipeline task queue framework and merge workers into one #64011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
jenkins test this |
brianseeders
force-pushed
the
pipeline-tasks
branch
from
73371cd to
950cdde
Compare
botelastic
bot
added
Feature:Drilldowns
|
Pinging @elastic/apm-ui (Team:apm) |
brianseeders
force-pushed
the
pipeline-tasks
branch
from
950cdde to
9102361
Compare
brianseeders
removed
Feature:Drilldowns
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
brianseeders
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
brianseeders
force-pushed
the
pipeline-tasks
branch
from
3237ef2 to
146946b
Compare
|
Hmm, any idea what this is? |
|
@elasticmachine merge upstream |
I've seen this before with docker builds and it seems to have a bunch of different causes (such as incompatible versions with old kernel versions). I think a |
💛 Build succeeded, but was flaky
Test FailuresFirefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder metric should populate fields for basic functionsStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jul 8, 2020
…astic#64011) # Conflicts: # src/dev/notice/generate_notice_from_source.ts # test/scripts/jenkins_build_kibana.sh # test/scripts/jenkins_ci_group.sh # test/scripts/jenkins_xpack_build_kibana.sh
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jul 8, 2020
…astic#64011) # Conflicts: # Jenkinsfile # src/dev/notice/generate_notice_from_source.ts # test/scripts/jenkins_build_kibana.sh # test/scripts/jenkins_ci_group.sh # test/scripts/jenkins_security_solution_cypress.sh # test/scripts/jenkins_xpack_build_kibana.sh # vars/kibanaPipeline.groovy
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 8, 2020
* master: (36 commits) fixed api url in example plugin (elastic#70934) [data.search.aggs]: Remove remaining client dependencies (elastic#70251) [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998) [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639) [SIEM][Detection Engine][Lists] Adds additional data types to value based lists [SIEM][Detection Engine][Lists] Removes feature flag for lists [APM] Show license callout in ML settings (elastic#70959) Migrate service settings test to jest (elastic#70992) [APM] Add cloud attributes to data telemetry (elastic#71008) Fix breadcrumb on panels for visibility / round corners (elastic#71010) Improve search typescript (elastic#69333) [savedObjects field count] run in baseline job (elastic#70999) [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988) [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874) [APM] Add API tests (elastic#70740) [Security Solution][Exceptions] - Tie server and client code together (elastic#70918) [Audit Logging] Add AuditTrail service (elastic#69278) [Usage Collection] Ensure no type duplicates (elastic#70946) [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958) [CI] Add pipeline task queue framework and merge workers into one (elastic#64011) ...
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jul 8, 2020
… one (elastic#64011)" This reverts commit 465ed21.
spalger
added a commit
that referenced
this pull request
Jul 8, 2020
* Revert "temporarily disable firefox functional tests in PRs (#71116)" This reverts commit 54bd07f. * Revert "[savedObjects field count] run in baseline job (#70999)" This reverts commit 53ee7a7. * Revert "[CI] Add pipeline task queue framework and merge workers into one (#64011)" This reverts commit 465ed21. * Revert revert of change to jenkins_xpack_visual_regression.sh Co-authored-by: spalger <spalger@users.noreply.github.com>
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jul 9, 2020
This reverts commit b6a06df.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "task queue" framework to pipelines. This allows CI to be broken down into lots of small units and run in parallel with a maximum level of concurrency. A "task" is just a closure that executes. So, this is like a more managed version of Jenkins's
parallel()block.This PR also adds a task queue to CI, breaks intake and functional jobs down into small units, and runs everything on the same worker. This means that "Intake" tasks can run while the builds are happening (while normally these extra resources would be wasted).
Each task "process" gets a unique copy of the workspace (with symlinked node_modules) to work out of, so tasks can modify files and such without affecting other tasks.
Some of the intake tasks have hard-coded ports and such for ES/Kibana, so I'm using Docker to run them in isolation and in parallel on the same machine.
As a note, I actually don't really like the idea of creating one huge pipeline that runs on one big machine. It's really difficult to efficiently use resources. This pipeline still has a lot of wasted resources. But, with our constraints (namely, needing to keep Jenkins agent count down to keep Jenkins stable) and the tools currently available to us, I think it will have to do. This at least doesn't lock us into one machine. Multiple task queues can be defined on multiple machines, so tasks can be split up and moved around as needed.
From the code: