Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Canvas] Top Menu (#59982) #64462

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 24, 2020

Backports the following commits to 7.x:

* Redesigned workpad_header to top menu layout

* Added comments

* Fixed element spec

* Removed element preview images

* Removed tooltip from menus

* Removed extraneous JSX

* Fixed element fixtures

* Moved component strings

* top menu design tweaks

* Added filter debug element

* Fix file picker in asset manager

* Sort components strings object keys

* Removed ElementTypes component in favor of SavedElementsModal

* Updated stories

* Fixed custom elements functional tests

* Removed unused tag strings

* Fixed test fixtures

* Updated element_menu stories

* Updated view_menu stories

* TS for SavedElementsModal

* Updated types

* Fixed TS errors

* Fix i18n errors

* Renamed stories

* Fixed test file name

* Fixed stories

* Updated storyshots

* Reverted storybook webpack config change

* Fixed SavedElementsModal stories

* Updated comments

* Removed unnecessary ts-ignores

* Moved workpad_shortcuts back to /components

* Unskip custom elements functional test

* Reverted workpad_loader changes

* Added element_menu stories and mocks

* Fixed element i18n strings

* Updated storyshots

* Updated storyshot

Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Elastic Machine <elCo-authored-by: Elastic ly.github.com>
@cqliu1
Copy link
Contributor Author

cqliu1 commented Apr 27, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 0112dd0 into elastic:7.x Apr 27, 2020
@cqliu1 cqliu1 deleted the backport/7.x/pr-59982 branch April 27, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants