Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fixes embed flyout #64468

Merged
merged 1 commit into from
Apr 27, 2020
Merged

[Canvas] Fixes embed flyout #64468

merged 1 commit into from
Apr 27, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 24, 2020 •
edited
Loading

Summary

This bug was introduced in #59982. The embed flyout wasn't opening when clicking on the Add from Visualize library button in the View menu. I passed false instead of true in showEmbedPanel, so the Add from Visualize library button didn't correctly trigger the flyout to open.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.8.0 labels Apr 24, 2020
@cqliu1 cqliu1 requested a review from a team as a code owner April 24, 2020 22:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

crob611
crob611 approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough

@cqliu1 cqliu1 force-pushed the fix/embed-flyout branch from c73a88a to e403173 Compare April 27, 2020 16:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #43220 succeeded c73a88a95d8f495d3d9086ddd3a51a4305e46593

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 merged commit 4e714c2 into elastic:master Apr 27, 2020
@cqliu1 cqliu1 deleted the fix/embed-flyout branch April 27, 2020 21:16
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Apr 27, 2020
@cqliu1
[Canvas] Fixes embed flyout (elastic#64468)
6d0fe14
@cqliu1 cqliu1 mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cqliu1 @elasticmachine @kibanamachine @crob611