Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis Editor] - console error on opening the Inspector from visualization editor #65277

Merged
merged 1 commit into from
May 5, 2020
Merged

[Vis Editor] - console error on opening the Inspector from visualization editor #65277

merged 1 commit into from
May 5, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 5, 2020

Closes: #65268

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp requested a review from streamich May 5, 2020 14:38
@alexwizp alexwizp self-assigned this May 5, 2020
@alexwizp alexwizp marked this pull request as ready for review May 5, 2020 14:41
@alexwizp alexwizp requested a review from a team May 5, 2020 14:41
@alexwizp alexwizp requested a review from a team as a code owner May 5, 2020 14:41
@alexwizp alexwizp added the Feature:Vis Editor Visualization editor issues label May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

streamich
streamich approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label May 5, 2020
flash1293
flash1293 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and flyout closes when navigating away from the current visualization. No errors in the console. LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit e864fd6 into elastic:master May 5, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request May 5, 2020
@alexwizp
[Vis Editor] - console error on opening the Inspector from visualizat…
7603815 
…ion editor (elastic#65277)

Closes: elastic#65268
@alexwizp alexwizp mentioned this pull request May 5, 2020
Merged
alexwizp added a commit that referenced this pull request May 5, 2020
@alexwizp
[Vis Editor] - console error on opening the Inspector from visualizat…
c03a823 
…ion editor (#65277) (#65348)

Closes: #65268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vis Editor] - console error on opening the Inspector from visualization editor
5 participants
@alexwizp @elasticmachine @kibanamachine @flash1293 @streamich