Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths #69723

Merged
merged 4 commits into from
Jun 26, 2020
Merged

[Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths #69723

merged 4 commits into from
Jun 26, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jun 23, 2020

Fixes #69400

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 23, 2020
@nreese nreese requested a review from kindsun June 23, 2020 17:45
@nreese nreese requested a review from a team as a code owner June 23, 2020 17:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from kindsun June 24, 2020 17:15
@nreese
Copy link
Contributor Author

nreese commented Jun 24, 2020

@elasticmachine merge upstream

kindsun
kindsun approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Small but worthwhile improvement, really helps readability and feels more organized. Thanks for the updates!

  • code review

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit be3886b into elastic:master Jun 26, 2020
nreese added a commit to nreese/kibana that referenced this pull request Jun 26, 2020
@nreese @elasticmachine
[Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL p…
0444049 
…aths (elastic#69723)

* [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths

* rename methods

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Jun 26, 2020
Merged
nreese added a commit that referenced this pull request Jun 26, 2020
@nreese @elasticmachine
[Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL p…
57d64fb 
…aths (#69723) (#70036)

* [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths

* rename methods

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 26, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
17fba6a 
* master: (34 commits)
  Upgrade `elliptic` dependency (`6.5.2` → `6.5.3`). (elastic#70054)
  [License Management] Do not break when `telemetry.enabled:false` (elastic#69711)
  [SECURITY] Redirect app/security to app/security/overview (elastic#70005)
  "Explore underlying data" in-chart action (elastic#69494)
  Api reference docs for state_containers and state_sync (elastic#67354)
  prep state transfer for passing embeddables by value to editor and back (elastic#69991)
  move Metrics API to start (elastic#69787)
  refactor: 💡 fix typo in embeddable (elastic#69417)
  [alerting] migrates the old `alerting` consumer to be `alerts` (elastic#69982)
  [APM]Create API to return data to be used on the Overview page (elastic#69137)
  [Lens] Fix delete button position in dimension panel for long labels (elastic#69495)
  [Lens] Add toolbar api (elastic#69263)
  Fixes bug on color picker defaults on TSVB (elastic#69889)
  [DOCS] Fixes wording in Upload a CSV section (elastic#69969)
  [Discover] Validate timerange before submitting query to ES (elastic#69363)
  [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723)
  [Maps] Fix icon palettes are not working (elastic#69937)
  [Ingest Manager] Fix typo in constant name (elastic#69919)
  [test] skip status.allowAnonymous tests on cloud (elastic#69017)
  Fix backport (elastic#70003)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 26, 2020
@jloleysens
Merge branch 'ingest-pipelines/editor-dropzone-refinement' into inges…
36645ca 
…t-pipelines/editor-error-messages

* ingest-pipelines/editor-dropzone-refinement: (122 commits)
  Fixes for monaco XJSON grammar parser and update form copy
  Added cancel move button
  Refactor SCSS values to variables
  use classNames as it is intended to be used
  Remove box shadow on all nested tree items
  Rename variables and prefix booleans with "is"
  Fixes bug on color picker defaults on TSVB (elastic#69889)
  [DOCS] Fixes wording in Upload a CSV section (elastic#69969)
  [Discover] Validate timerange before submitting query to ES (elastic#69363)
  [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723)
  [Maps] Fix icon palettes are not working (elastic#69937)
  [Ingest Manager] Fix typo in constant name (elastic#69919)
  [test] skip status.allowAnonymous tests on cloud (elastic#69017)
  Fix backport (elastic#70003)
  [Reporting] ReportingStore module (elastic#69426)
  Add reporting assets to the eslint ignore file (elastic#69968)
  [Discover] set minBarHeight for high cardinality data (elastic#69875)
  Add featureUsage API to licensing context provider (elastic#69838)
  Fix uncaught typecheck merge conflict (elastic#70001)
  Use TS to discourage SO mappings with dynamic: false / dynamic: true (elastic#69927)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Do not use MAP_SAVED_OBJECT_TYPE constant when defining URL paths
4 participants
@nreese @elasticmachine @kibanamachine @kindsun