Add featureUsage API to licensing context provider #69838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
commented
Jun 24, 2020
pgayvallet
approved these changes
Jun 25, 2020
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jun 25, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 26, 2020
…t-pipelines/editor-error-messages * ingest-pipelines/editor-dropzone-refinement: (122 commits) Fixes for monaco XJSON grammar parser and update form copy Added cancel move button Refactor SCSS values to variables use classNames as it is intended to be used Remove box shadow on all nested tree items Rename variables and prefix booleans with "is" Fixes bug on color picker defaults on TSVB (elastic#69889) [DOCS] Fixes wording in Upload a CSV section (elastic#69969) [Discover] Validate timerange before submitting query to ES (elastic#69363) [Maps] avoid using MAP_SAVED_OBJECT_TYPE constant when defining URL paths (elastic#69723) [Maps] Fix icon palettes are not working (elastic#69937) [Ingest Manager] Fix typo in constant name (elastic#69919) [test] skip status.allowAnonymous tests on cloud (elastic#69017) Fix backport (elastic#70003) [Reporting] ReportingStore module (elastic#69426) Add reporting assets to the eslint ignore file (elastic#69968) [Discover] set minBarHeight for high cardinality data (elastic#69875) Add featureUsage API to licensing context provider (elastic#69838) Fix uncaught typecheck merge conflict (elastic#70001) Use TS to discourage SO mappings with dynamic: false / dynamic: true (elastic#69927) ...
joshdover
added a commit
that referenced
this pull request
Jun 26, 2020
smith
added a commit
to smith/kibana
that referenced
this pull request
Jun 26, 2020
We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
smith
added a commit
that referenced
this pull request
Jun 29, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in #69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In #69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
smith
added a commit
to smith/kibana
that referenced
this pull request
Jun 29, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
smith
added a commit
that referenced
this pull request
Jun 29, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in #69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In #69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows access to the feature usage API inside HTTP route handlers:
Checklist
Delete any items that are not applicable to this PR.
For maintainers