Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Fix a bug in Metric Threshold query filter construction #70672

Merged
merged 3 commits into from
Jul 6, 2020
Merged

[Metrics UI] Fix a bug in Metric Threshold query filter construction #70672

merged 3 commits into from
Jul 6, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jul 2, 2020 •
edited
Loading

Summary

Possible resolution to #68492

Some leftover stuff that wasn't taken out in #64937 led to the Metric Threshold alert creating filter queries that were, at best, unoptimized, and at worst, overrode the range and exists filters so that the alert would query way too much data and trigger a bucket limit.

This fixes that bug, and also adds tests ensuring that the metric threshold alert will always have range and metric field exists filters.

Might be worthy of backporting to a 7.8 patch release?

Checklist

@Zacqary Zacqary added release_note:fix Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jul 2, 2020
@Zacqary Zacqary requested a review from simianhacker July 2, 2020 22:23
@Zacqary Zacqary requested a review from a team as a code owner July 2, 2020 22:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary mentioned this pull request Jul 2, 2020
Closed
@Zacqary
Copy link
Contributor Author

Zacqary commented Jul 6, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary added the v7.8.2 label Jul 6, 2020
simianhacker
simianhacker approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 11cfe80 into elastic:master Jul 6, 2020
@Zacqary Zacqary deleted the 68492-threshold-query-optimize branch July 6, 2020 20:33
@Zacqary Zacqary mentioned this pull request Jul 6, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jul 6, 2020
@Zacqary @elasticmachine
[Metrics UI] Fix a bug in Metric Threshold query filter construction (e…
77aa8fb 
…lastic#70672)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Zacqary Zacqary mentioned this pull request Jul 6, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jul 6, 2020
@Zacqary
[Metrics UI] Fix a bug in Metric Threshold query filter construction (e…
16722d9 
…lastic#70672)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts
Zacqary added a commit that referenced this pull request Jul 6, 2020
@Zacqary @elasticmachine
[Metrics UI] Fix a bug in Metric Threshold query filter construction (#…
09d9180 
…70672) (#70875)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
ae3c7a7 
* master: (53 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'master' into actions/feature
61626a0 
* master: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
@gmmorris
Merge branch 'actions/feature' into actions/feature-and-rbac
a73fff5 
* actions/feature: (46 commits)
  [Composable template] Details panel + delete functionality (elastic#70814)
  [Uptime] Ping list body scroll (elastic#70781)
  moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430)
  Adapt expected response of advanced settings feature control for cloud tests (elastic#70793)
  skip flaky suite (elastic#70885)
  skip flaky suite (elastic#67814)
  skip flaky suite (elastic#70906)
  Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908)
  Added UI validation when creating a Webhook connector with invalid URL (elastic#70025)
  [Security Solution] Change default index pattern (elastic#70797)
  ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464)
  add button link to ingest (elastic#70142)
  reenable regression and classification functional tests (elastic#70661)
  [Component templates] Form wizard (elastic#69732)
  [Ingest Manager] Copy changes (elastic#70828)
  Adding test user to maps functional tests - PR 1 (elastic#70649)
  [Ingest Manager] Support limiting integrations on an agent config (elastic#70542)
  skip flaky suite (elastic#70880)
  [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672)
  upgrade caniuse-lite database (elastic#70833)
  ...
Zacqary added a commit that referenced this pull request Jul 7, 2020
@Zacqary @elasticmachine
[7.8] [Metrics UI] Fix a bug in Metric Threshold query filter constru…
5fbf2d4 
…ction (#70672) (#70879)

* [Metrics UI] Fix a bug in Metric Threshold query filter construction (#70672)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts

* Manual backport of changes to getElasticsearchMetricQuery

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@EamonnTP
Copy link

EamonnTP commented Aug 5, 2020

Hi @Zacqary Should this be included in the 7.9.0 release notes? I don't see it listed here: https://github.com/elastic/kibana/blob/0afaba21b39709739086e2aaa3a88a8a1bea855b/docs/CHANGELOG.asciidoc

@Zacqary
Copy link
Contributor Author

Zacqary commented Aug 5, 2020

@EamonnTP Yeah I think it should be in there. Maybe the 7.8.2 tag prevented it from getting added automatically?

@Zacqary Zacqary mentioned this pull request Aug 5, 2020
Merged
1 task
@EamonnTP EamonnTP mentioned this pull request Aug 5, 2020
Merged
1 task
@EamonnTP
Copy link

EamonnTP commented Aug 5, 2020

@Zacqary Possibly. I will get this, along with #71335 and #71340 added to the 7.9.0 release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.2 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zacqary @elasticmachine @kibanamachine @EamonnTP @simianhacker