ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) #68464

YulNaumenko · 2020-06-06T03:17:23Z

Current PR contains a basic ServiceNow push to Incident integration.
Support both Case and generic Alerts ServiceNow incident.
For each alert actions execution we create a new ServiceNow incident - current decision to keep incidents grouping on the customer side.
Till the next steps of integration will be done, keep some Case related types and code scoped by the conditions.

Should resolve #61138

…ow-general-usage # Conflicts: # x-pack/plugins/siem/public/cases/containers/use_post_push_to_service.tsx # x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/servicenow/index.ts

…Cases and Alerts

elasticmachine · 2020-06-12T00:58:29Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

…ow-general-usage # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

src/core/public/application/ui/app_router.tsx

…ow-general-usage # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

chrisronline

LGTM for Stack Monitoring

x-pack/plugins/security_solution/public/cases/containers/configure/use_connectors.tsx

…erver side

…ow-general-usage # Conflicts: # x-pack/plugins/security_solution/public/common/lib/connectors/servicenow/translations.ts

cnasikas

LGTM from Cases perspective! Thank you!

…ow-general-usage # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

gmmorris · 2020-07-03T09:38:42Z

Realizing that with the new RBAC work for alerts in PR #67157 that deals with consumer, and that I think there will be some RBAC work with actions later, @gmmorris should probably take a peek at this to see if there's anything in this PR that will affect that future work.

Hmm this is interesting - when @mikecote and I discussed RBAC for Actions we explicitly came to the conclusion that consumer isn't relevant to actions in general and hence to RBAC, so I'll have to take a deeper look at this PR to understand why we're introducing a consumer field.
Thanks for the heads up.

I removed API consumer field and replaced it with the action (connector) config property isCaseOwned.

thanks @YulNaumenko 🙏

…ow-general-usage # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

kibanamachine · 2020-07-06T23:34:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f44e4e8

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	786	-5	791
triggers_actions_ui	151	+5	146
total	-	-0	-

History

💔 Build #59073 failed 591b9b6
💔 Build #59028 failed eddbd87
💔 Build #58789 failed f333f42
💔 Build #58783 failed 31a991b
💔 Build #58571 failed f769478

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ase specific and generic Alerts) (elastic#68464) * Draft ServiceNow generic implementation * simple working servicenow incident per alert * fixed running times * rely on externalId for update incident on the next execution * Added consumer to the action type to be able to split ServiceNow for Cases and Alerts * Added subActions support for ServiceNow action form * Basic version for Alerts part for ServiceNow * Keep Case ServiceNow functionality working * Revert changes on app_router * Fixed type checks * Fixed language check issues * Fixed actions unit tests * Fixed functional tests * Fixed jest tests * fixed tests * Copied case mappings to alerting plugin * made consumer optional * Cleanup tests * more cleanup * Fixed jest tests and type checks * fixed tests * fixed servicenow validation tests * Added ServiceNow unit tests * Removed consumer for actions * fixed client side isCaseOwned support * fixed failing tests * fixed jest tests * Fixed URL validation * fixed due to comments * fixed tests * fixed jest tests * Fixed due to comments. Moved ServiceNow filtering in case plugin to server side * fixed mock for ServiceNow * fixed consumer config * fixed test * fixed type check * Fixed jest test * fixed type check

* master: (53 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

* master: (46 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

* actions/feature: (46 commits) [Composable template] Details panel + delete functionality (elastic#70814) [Uptime] Ping list body scroll (elastic#70781) moving indexPattern.delete() to indexPatterns.delete(indexPattern) (elastic#70430) Adapt expected response of advanced settings feature control for cloud tests (elastic#70793) skip flaky suite (elastic#70885) skip flaky suite (elastic#67814) skip flaky suite (elastic#70906) Revert "reenable regression and classification functional tests (elastic#70661)" (elastic#70908) Added UI validation when creating a Webhook connector with invalid URL (elastic#70025) [Security Solution] Change default index pattern (elastic#70797) ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (elastic#68464) add button link to ingest (elastic#70142) reenable regression and classification functional tests (elastic#70661) [Component templates] Form wizard (elastic#69732) [Ingest Manager] Copy changes (elastic#70828) Adding test user to maps functional tests - PR 1 (elastic#70649) [Ingest Manager] Support limiting integrations on an agent config (elastic#70542) skip flaky suite (elastic#70880) [Metrics UI] Fix a bug in Metric Threshold query filter construction (elastic#70672) upgrade caniuse-lite database (elastic#70833) ...

…both Case specific and generic Alerts) (#68464) (#70898) * ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (#68464) * Draft ServiceNow generic implementation * simple working servicenow incident per alert * fixed running times * rely on externalId for update incident on the next execution * Added consumer to the action type to be able to split ServiceNow for Cases and Alerts * Added subActions support for ServiceNow action form * Basic version for Alerts part for ServiceNow * Keep Case ServiceNow functionality working * Revert changes on app_router * Fixed type checks * Fixed language check issues * Fixed actions unit tests * Fixed functional tests * Fixed jest tests * fixed tests * Copied case mappings to alerting plugin * made consumer optional * Cleanup tests * more cleanup * Fixed jest tests and type checks * fixed tests * fixed servicenow validation tests * Added ServiceNow unit tests * Removed consumer for actions * fixed client side isCaseOwned support * fixed failing tests * fixed jest tests * Fixed URL validation * fixed due to comments * fixed tests * fixed jest tests * Fixed due to comments. Moved ServiceNow filtering in case plugin to server side * fixed mock for ServiceNow * fixed consumer config * fixed test * fixed type check * Fixed jest test * fixed type check * fixed internationalization check

Draft ServiceNow generic implementation

d16c22e

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.9.0 labels Jun 6, 2020

YulNaumenko linked an issue Jun 8, 2020 that may be closed by this pull request

Add ServiceNow action type #61138

Closed

YulNaumenko added 8 commits June 8, 2020 08:08

simple working servicenow incident per alert

53ac886

fixed running times

7c529a0

rely on externalId for update incident on the next execution

cb5e3b2

Added consumer to the action type to be able to split ServiceNow for …

5f9d371

…Cases and Alerts

Added subActions support for ServiceNow action form

d3db873

Basic version for Alerts part for ServiceNow

9ea3450

Keep Case ServiceNow functionality working

ae59bcd

YulNaumenko marked this pull request as ready for review June 12, 2020 00:58

YulNaumenko requested review from a team as code owners June 12, 2020 00:58

YulNaumenko changed the title ~~Draft ServiceNow generic implementation~~ ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) Jun 12, 2020

pgayvallet reviewed Jun 12, 2020

View reviewed changes

src/core/public/application/ui/app_router.tsx Outdated Show resolved Hide resolved

YulNaumenko added 3 commits June 12, 2020 09:38

Revert changes on app_router

2a988e1

Fixed type checks

6a61abe

YulNaumenko requested a review from a team June 15, 2020 18:56

chrisronline approved these changes Jun 15, 2020

View reviewed changes

Fixed language check issues

819e002

YulNaumenko added 2 commits June 29, 2020 20:11

fixed tests

8757548

fixed jest tests

a3d29e4

cnasikas reviewed Jun 30, 2020

View reviewed changes

x-pack/plugins/security_solution/public/cases/containers/configure/use_connectors.tsx Outdated Show resolved Hide resolved

YulNaumenko added 2 commits June 30, 2020 08:30

Fixed due to comments. Moved ServiceNow filtering in case plugin to s…

2eafff5

…erver side

Merge remote-tracking branch 'upstream/master' into actions-service-n…

c2041f1

…ow-general-usage # Conflicts: # x-pack/plugins/security_solution/public/common/lib/connectors/servicenow/translations.ts

cnasikas approved these changes Jun 30, 2020

View reviewed changes

YulNaumenko added 3 commits June 30, 2020 12:06

fixed mock for ServiceNow

e83f57f

Merge master

c74e791

cnasikas mentioned this pull request Jul 2, 2020

[SIEM][CASE] IBM Resilient Connector #66385

Merged

4 tasks

YulNaumenko added 2 commits July 2, 2020 16:08

fixed consumer config

f769478

YulNaumenko added 6 commits July 5, 2020 15:42

fixed test

31a991b

fixed type check

f333f42

Fixed jest test

eddbd87

fixed type check

591b9b6

Merge master

f44e4e8

YulNaumenko merged commit 57915e1 into elastic:master Jul 6, 2020

YulNaumenko mentioned this pull request Jul 6, 2020

[7.x] ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) (#68464) #70898

Merged

mikecote mentioned this pull request Sep 1, 2020

[Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) #73778

Merged

7 tasks

cnasikas mentioned this pull request Sep 21, 2020

[Actions] Migrate cases configuration object #77998

Merged

2 tasks

cnasikas mentioned this pull request Oct 15, 2020

[Security Solution][Cases] Fix bug with case connectors #80642

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) #68464

ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) #68464

YulNaumenko commented Jun 6, 2020 •

edited

Loading

elasticmachine commented Jun 12, 2020

chrisronline left a comment

cnasikas left a comment

gmmorris commented Jul 3, 2020

kibanamachine commented Jul 6, 2020

ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) #68464

ServiceNow push to Incident generic implementation (supporting both Case specific and generic Alerts) #68464

Conversation

YulNaumenko commented Jun 6, 2020 • edited Loading

elasticmachine commented Jun 12, 2020

chrisronline left a comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

gmmorris commented Jul 3, 2020

kibanamachine commented Jul 6, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

YulNaumenko commented Jun 6, 2020 •

edited

Loading