-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] Migrate cases configuration object #77998
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
I'd suggest adding an end-to-end test for this, as I think you might find that this update results in a partial update which means you'll end up with the I can't recall if the migration uses If so, you'll need to reset Here's an example of how this can be achieved: https://github.com/elastic/kibana/blob/master/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/migrations.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I agree with Gidi, that it would be very useful to have end-to-end test for like he proposed. So, please add a functional test and don't hesitate to contact me if you need any help on this.
Thanks a lot! I will add an end-to-end test for this. Migrations do not update the SO. They create a new index, read your SO from the old index, transform it as your likes, and then the new SO will be added to the new index. Its more like a delete and create operation than an update.
Thank you! I will! |
9cfa837
to
e96b6c5
Compare
e96b6c5
to
410940d
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gidi Meir Morris <github@gidi.io> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Gidi Meir Morris <github@gidi.io>
Summary
#73778, #74357, and #68464 renamed the cases configuration object from
casesConfiguration
toincidentConfiguration
. This PR creates a migration to accommodate this change.Checklist
Delete any items that are not applicable to this PR.
For maintainers