-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS 3.9 Project references #71736
TS 3.9 Project references #71736
Conversation
…ownstream projects
We need declaration: true to use incremental builds. But when generating declaration files new TS errors show up. This commit fixes errors like: Exported variable 'expressionsPluginMock' has or is using name 'MockedElasticSearchServiceSetup' from external module "/Users/rudolf/dev/kibana/src/core/server/elasticsearch/elasticsearch_service.mock" but cannot be named.
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_create_index_pattern_wizard·js.management "Create Index Pattern" wizard data streams can be an index patternStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard Out
Stack Trace
Build metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
With TS v4 very close I think we should close this in favor of #72280. If we start to run into issues that are going to significantly slow down our 4.0 upgrade, we can reconsider going with this route. But otherwise, doing in this 4.0 requires a lot fewer changes to enable incremental builds (due to not having to emit any declaration files). |
Summary
Typescript project references and incremental builds to speed up performance. I've been fairly aggressive in either excluding typechecking or adding
any
to get the typechecker to work. I hope to get to fully working project references first and then pulling in teams to see if they can help solve the remaining type errors in a more elegant way.Status
Checklist
Delete any items that are not applicable to this PR.
For maintainers