-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts 4 project references and incremental builds #72280
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ownstream projects
It seems like eslint isn't happy with TS4, got the following error but didn't investigate:
|
rudolf
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Jul 17, 2020
Causes 34 type errors:
|
💔 Build Failed
Failed CI Steps
Build metricsTo update your PR or re-run it, just comment with: |
Merged
7 tasks
jinmu03
changed the title
Ts 4 project references
Ts 4 project references and incremental builds
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developing Typescript with VSCode is currently frustratingly slow:
Opening files in another one of Kibana's 24 independent typescript projects sometimes takes > 60s "initializing TS language features"
cmd+clicking references within some projects takes > 60s (in my experience test seems to be the slowest)
Not all type errors show up under VSCode's "problems"
Running a complete typecheck takes > 60s which slows down the development cycle when doing large type refactors
I believe using [typescript references](https://www.typescriptlang.org/docs/handbook/project-references.html and incremental builds we should be able to make the build time much faster, have type errors show up without having to run scripts/type_check and improve type lookups and navigation in VSCode.
Summary
Blocked by: #71932
This is similar to #71736 but without any 3.9 type fixes (which comes from 3.9 having to emit declaration files). So this is probably the best place to start to further persue project references based on TS 4 beta.
Checklist
Delete any items that are not applicable to this PR.
For maintainers