-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY] Timeline bug 7.9 #71748
[SECURITY] Timeline bug 7.9 #71748
Conversation
Pinging @elastic/siem (Team:SIEM) |
...lugins/security_solution/public/timelines/components/timeline/body/events/stateful_event.tsx
Outdated
Show resolved
Hide resolved
actionsColumnWidth={actionsColumnWidth} | ||
addNoteToEvent={addNoteToEvent} | ||
browserFields={browserFields} | ||
columnHeaders={columnHeaders} | ||
columnRenderers={columnRenderers} | ||
containerElementRef={containerElementRef} | ||
disableSensorVisibility={data != null && data.length < 101} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart :)
} from '../../../timelines/components/open_timeline/helpers'; | ||
import { updateIsLoading as dispatchUpdateIsLoading } from '../../../timelines/store/timeline/actions'; | ||
|
||
export const useTimelineClick = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
newUrlStateString: updatedUrlStateString, | ||
}, | ||
]; | ||
if (updateTimelineAtinitialization(urlKey, newUrlStateString, urlState)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can't this be combined with the if above this?
if (
isInitializing ||
(!deepEqual(updatedUrlStateString, newUrlStateString) &&
updateTimelineAtinitialization(urlKey, newUrlStateString, urlState))
) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so because isInitializing
will take over my function updateTimelineAtinitialization
dc0d03e
to
0adabc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review looks good (besides conflicts and type err which i know you'll fix), manual testing all looks good for the different bug conditions. LGTM!
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
miscellaneous assets size
History
To update your PR or re-run it, just comment with: |
* remove delay of rendering row * Fix flyout timeline to behave as we wanted * Fix tabs on timeline page * disable sensor visibility when you have less than 100 events in timeline * Fix container to fit content and not take all the place that it wants * do not update timeline time when switching top nav * fix timeline url in case * review I Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: (82 commits) Fixed the spacing of child accordion items for policy response dialog. (elastic#71677) [SECURITY] Timeline bug 7.9 (elastic#71748) use fixed isChromeVisible method (elastic#71813) [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted (elastic#71792) [test] Skips flaky Saved Objects Management test [APM] Remove watcher integration (elastic#71655) [APM] Increase `xpack.apm.ui.transactionGroupBucketSize` (elastic#71661) [test] Skips Ingest Manager test preventing ES promotion [test] Skips flaky detection engine tests Revert "re-fix navigate path for master add SAML login to login_page (elastic#71337)" [tests] Temporarily skipped Fleet tests [test] Skipped monitoring test [Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update (elastic#71794) Add endpoint exception creation API validation (elastic#71791) Skip jest tests that timeout waiting for react (elastic#71801) [Security Solution][Exceptions] - Adds filtering to endpoint index patterns by exceptional fields (elastic#71757) [Reporting] Re-delete a file (elastic#71730) [Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768) [Ingest Manager] Better display of Fleet requirements (elastic#71686) [tests] Temporarily skipped to promote snapshot ...
* remove delay of rendering row * Fix flyout timeline to behave as we wanted * Fix tabs on timeline page * disable sensor visibility when you have less than 100 events in timeline * Fix container to fit content and not take all the place that it wants * do not update timeline time when switching top nav * fix timeline url in case * review I Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers