-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted #71792
Conversation
…ate the endpoint_list if it gets deleted
x-pack/plugins/lists/common/schemas/request/update_endpoint_list_item_schema.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/lists/server/services/exception_lists/create_endpoint_list.ts
Outdated
Show resolved
Hide resolved
|
||
// This will create the endpoint list if it does not exist yet | ||
await context.lists?.getExceptionListClient().createEndpointList(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaaaank you! 🙏
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the "create endpoint list during rule creation" flow, along with the "associate endpoint list to rule" flow, and both look great! 👍 👍 👍
Up to you if you wanna merge this now and add tests afterwards. Either way I'm gonna have to circle back on #71794, mainly to use the ENDPOINT_LIST_ID constant.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
* master: (82 commits) Fixed the spacing of child accordion items for policy response dialog. (elastic#71677) [SECURITY] Timeline bug 7.9 (elastic#71748) use fixed isChromeVisible method (elastic#71813) [SIEM][Detection Engine][Lists] Adds specific endpoint_list REST API and API for abilities to auto-create the endpoint_list if it gets deleted (elastic#71792) [test] Skips flaky Saved Objects Management test [APM] Remove watcher integration (elastic#71655) [APM] Increase `xpack.apm.ui.transactionGroupBucketSize` (elastic#71661) [test] Skips Ingest Manager test preventing ES promotion [test] Skips flaky detection engine tests Revert "re-fix navigate path for master add SAML login to login_page (elastic#71337)" [tests] Temporarily skipped Fleet tests [test] Skipped monitoring test [Security Solution][Detections] Associate Endpoint Exceptions List to Rule during rule creation/update (elastic#71794) Add endpoint exception creation API validation (elastic#71791) Skip jest tests that timeout waiting for react (elastic#71801) [Security Solution][Exceptions] - Adds filtering to endpoint index patterns by exceptional fields (elastic#71757) [Reporting] Re-delete a file (elastic#71730) [Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768) [Ingest Manager] Better display of Fleet requirements (elastic#71686) [tests] Temporarily skipped to promote snapshot ...
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Adds specific endpoint list REST API and API for abilities to auto-create the endpoint_list if it gets deleted or to auto-provision it when a rule is first created.
When auto-creating the endpoint_list it does so using these values for the saved object:
The new API endpoints are as follows below. These endpoints are like the normal exception list item endpoints except you should not pass down any
list_id
ornamespace_type
since these are focused specific endpoints against the space agnostic endpoint_listNew API within the exception_list_client plugin are:
Scripts for testing are:
Checklist
Delete any items that are not applicable to this PR.