Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix HTML named characters encoding #72060

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Fixed #71223. Improved escaping of HTML characters by using HTML entities encoder.
Jul-16-2020 16-32-42

Checklist

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 391 +1 390

page load bundle size

id value diff baseline
ml 4.3MB +76.2KB 4.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov requested a review from spalger July 17, 2020 10:24
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@darnautov darnautov merged commit 8f442f8 into elastic:master Jul 17, 2020
@darnautov darnautov deleted the ML-71223-fix-cell-indication branch July 17, 2020 14:37
darnautov added a commit to darnautov/kibana that referenced this pull request Jul 17, 2020
* [ML] improve special characters encoding

* [ML] update renovate.json5
darnautov added a commit to darnautov/kibana that referenced this pull request Jul 17, 2020
* [ML] improve special characters encoding

* [ML] update renovate.json5
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
* master:
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 17, 2020
…feature-privileges

* alerting/consumer-based-rbac:
  corrected consumer on enable operation
  [ML] Remove DragSelect event handlers and selectors on the swim lane unmount  (elastic#72250)
  Add a few asciidoc readmes (elastic#72082)
  re-enable tests. retry on fail (elastic#72061)
  updates advanced settings text (elastic#72249)
  [ML] Fix HTML named characters encoding (elastic#72060)
  Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231)
  Observability landing page title (elastic#72088)
  [QA][Code Coverage] Drop flaky integration tests (elastic#72089)
  [Ingest Manager] Fix failing test conflict error (elastic#72149)
  [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693)
  [SECURITY] Bug truncation on timeline (elastic#72221)
  skip flaky suite (elastic#72146)
darnautov added a commit that referenced this pull request Jul 17, 2020
* [ML] improve special characters encoding

* [ML] update renovate.json5
darnautov added a commit that referenced this pull request Jul 17, 2020
* [ML] improve special characters encoding

* [ML] update renovate.json5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Swim lane cell selection not indicated if influencer contains a backslash character
6 participants