[SECURITY] Bug truncation on timeline #72221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
approved these changes
Jul 17, 2020
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jul 17, 2020
* bring back truncated ceil + only show menu context hover text * update unit test
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jul 17, 2020
* bring back truncated ceil + only show menu context hover text * update unit test
XavierM
added a commit
that referenced
this pull request
Jul 17, 2020
XavierM
added a commit
that referenced
this pull request
Jul 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
* master: [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 17, 2020
…feature-privileges * alerting/consumer-based-rbac: corrected consumer on enable operation [ML] Remove DragSelect event handlers and selectors on the swim lane unmount (elastic#72250) Add a few asciidoc readmes (elastic#72082) re-enable tests. retry on fail (elastic#72061) updates advanced settings text (elastic#72249) [ML] Fix HTML named characters encoding (elastic#72060) Bump @elastic/elasticsearch to v7.9.0-rc1 (elastic#72231) Observability landing page title (elastic#72088) [QA][Code Coverage] Drop flaky integration tests (elastic#72089) [Ingest Manager] Fix failing test conflict error (elastic#72149) [Logs UI] Fix display of dataset values in anomaly and category example rows (elastic#71693) [SECURITY] Bug truncation on timeline (elastic#72221) skip flaky suite (elastic#72146)
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a recent PR, I was trying to only allow to show the menu context to filter in/out + send to timeline + top N + copy to clipboard when you go over the text of draggable and by doing that I broke the truncation. So this PR is my redemption to fix that.