Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENDPOINT] Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. #73662

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

efreeti
Copy link
Contributor

@efreeti efreeti commented Jul 29, 2020

Summary

Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.

image

Checklist

Delete any items that are not applicable to this PR.

…PI that is more widely used in Kibana and Security solution in particular.
@efreeti efreeti added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.10.0 v7.9.0 labels Jul 29, 2020
@efreeti efreeti requested review from a team as code owners July 29, 2020 13:22
@efreeti efreeti self-assigned this Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

…bala/toast-close-button

� Conflicts:
�	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efreeti efreeti merged commit 20de32a into elastic:master Jul 29, 2020
@efreeti efreeti deleted the btsymbala/toast-close-button branch July 29, 2020 19:15
@efreeti efreeti changed the title Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. [ENDPOINT] Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. Jul 29, 2020
@efreeti efreeti removed the v7.9.0 label Jul 29, 2020
efreeti added a commit to efreeti/kibana that referenced this pull request Jul 29, 2020
…PI that is more widely used in Kibana and Security solution in particular. (elastic#73662)

* Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.

* Fixed type check errors.

* Fixed tests.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -534.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

efreeti added a commit that referenced this pull request Jul 30, 2020
…PI that is more widely used in Kibana and Security solution in particular. (#73662) (#73729)

* Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.

* Fixed type check errors.

* Fixed tests.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
* master:
  [Vega][Inspector] Request panel should show correct names for requests (elastic#73655)
  [Security Solution] Update filter (elastic#73350)
  TSVB Inaccurate Group By (elastic#73683)
  [Vega][Inspect panel] Write tutorials and reference (elastic#73262)
  [ML] Removing node info check for file data viz import (elastic#73717)
  check that pathname has been updated. ignore other parts (elastic#73689)
  [build] rewrite source as transpiled JS later in the process (elastic#73749)
  Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734)
  skip flaky suite (elastic#69783) (elastic#70043)
  [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588)
  skip failing suite (elastic#58815)
  [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732)
  [DOCS] Changes level offset of monitoring pages (elastic#73573)
  Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662)
  [ML] Transforms/DFA: Change action button size back to 'xs'.
  [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545)
  [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants