-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENDPOINT] Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. #73662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI that is more widely used in Kibana and Security solution in particular.
efreeti
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Endpoint Management
Feature:Endpoint
Elastic Endpoint feature
v7.10.0
v7.9.0
labels
Jul 29, 2020
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
…bala/toast-close-button � Conflicts: � x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
parkiino
approved these changes
Jul 29, 2020
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/index.tsx
Show resolved
Hide resolved
kevinlog
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
efreeti
changed the title
Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.
[ENDPOINT] Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.
Jul 29, 2020
efreeti
added a commit
to efreeti/kibana
that referenced
this pull request
Jul 29, 2020
…PI that is more widely used in Kibana and Security solution in particular. (elastic#73662) * Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. * Fixed type check errors. * Fixed tests.
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 30, 2020
* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Endpoint
Elastic Endpoint feature
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular.
Checklist
Delete any items that are not applicable to this PR.