-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] rename GisMap to MapContainer and convert to TS #73690
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
if (_.isEqual(nextIndexPatternIds, this._prevIndexPatternIds)) { | ||
// all ready loaded index pattern ids | ||
return; | ||
} | ||
|
||
this._prevIndexPatternIds = nextIndexPatternIds; | ||
|
||
const geoFields = []; | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed try/catch because getIndexPatternsFromIds has try/catch once #73337 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested in chrome.
<MapContainer | ||
addFilters={this.input.hideFilterActions ? null : this.addFilters} | ||
renderTooltipContent={this._renderTooltipContent} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for cleanup!
* [maps] rename GisMap to MapContainer and convert to TS * fix typo in _index.scss
* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)
…ibana into actions/webhook-remove-header * 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485) [Maps] fix fit to data for Point to Point layer (elastic#73563) [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) ...
This PR renames GisMap to MapContainer and convert MapContainer to TS. The PR also removes the lazy loading of MapContainer in MapEmbeddable since MapEmbeddable itself is lazy loaded.