Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" #72473

Merged
merged 8 commits into from
Jul 29, 2020

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Jul 20, 2020

Summary

This PR adds links to the callout beyond "wait for snapshot policy" combobox in delete phase of an index lifecycle policy. The links are added to the callout when there are no snapshot policy yet created or when the user types in a value that doesn't match any existing snapshot policies. The links open in a new tab and redirect to the snapshot policy creation wizard. Both callouts are also changed to "normal" size to make them consistent with other callouts on the page.

No policies

Screenshot 2020-07-20 at 17 17 15

Value doesn't match any policies

Screenshot 2020-07-20 at 17 19 03

Release Note

We added links to "wait for snapshot policy" combobox that navigate to the snapshot policy creation wizard, when there no policies created yet or the value doesn't match any existing policies.

@yuliacech yuliacech requested a review from a team as a code owner July 20, 2020 16:26
@yuliacech yuliacech added Feature:ILM release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0 labels Jul 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@yuliacech yuliacech force-pushed the snapshot_policies_links branch from cbd6603 to 8d59fd3 Compare July 21, 2020 08:50
@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #72473 updated]

  • Start Time: 2020-07-21T11:01:19.541+0000

  • Duration: 5 min 20 sec

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@yuliacech
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
indexLifecycleManagement 274.5KB +1.0KB 273.5KB

page load bundle size

id value diff baseline
indexLifecycleManagement 238.4KB +140.0B 238.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this enhancement @yuliacech! Tested locally and works as expected.

I think there is room to make this an even better experience, but I don’t think it’s blocking. I’ll leave it up to you if you’d like to address it or not.

In CCR, if a user tries to create a follower index and doesn’t have a remote cluster configured, they are prompted as follows:

Screen Shot 2020-07-28 at 2 25 10 PM

If they go to create a new remote cluster and save, they are then redirected back to CCR to finish creating the follower index.

Screen Shot 2020-07-28 at 2 50 58 PM

I think it would be cool if we could do the same thing in ILM. The current implementation feels a little disjointed in that I have to click the link to create a policy, go to the new tab, create the policy, go back to the ILM tab, then refresh the page to see my new policy populated in the dropdown.

Another nice to have - if a user adds a policy name that doesn’t exist yet, when they hit “create a new policy”, the “Add policy” page would be populated with the selected name already.

@yuliacech
Copy link
Contributor Author

Hi @alisonelizabeth ,

thank you so much for your review! I agree that creation of a new policy needs a better user flow. I added this as a task to my ILM-improvement meta issue and will address in a subsequent PR. CCR is a great example that I will use as a guide.

@yuliacech yuliacech merged commit 34e70ef into elastic:master Jul 29, 2020
yuliacech added a commit to yuliacech/kibana that referenced this pull request Jul 29, 2020
… policy" (elastic#72473)

* [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy"

* [ILM] Fix jest tests

* [ILM] Fix jest integration tests

* [ILM] Fix eslint error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
yuliacech added a commit to yuliacech/kibana that referenced this pull request Jul 30, 2020
… policy" (elastic#72473)

* [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy"

* [ILM] Fix jest tests

* [ILM] Fix jest integration tests

* [ILM] Fix eslint error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
yuliacech added a commit that referenced this pull request Jul 30, 2020
…apshot policy" (#72473) (#73788)

* [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (#72473)

* [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy"

* [ILM] Fix jest tests

* [ILM] Fix jest integration tests

* [ILM] Fix eslint error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [ILM] Fix internalization error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@yuliacech yuliacech deleted the snapshot_policies_links branch August 6, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ILM release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants