Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize DFA navigation and index pattern handling #73660

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[ML] Functional tests - stabilize DFA navigation and index pattern handling #73660

merged 1 commit into from
Jul 29, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jul 29, 2020

Summary

This PR adds a few stability fixes around DFA creation and cloning.

Details

  • Add retries to DFA wizard navigation to deal with timing issues when the Next button is disabled
  • Increase the number of fetched index patterns when searching by title - the implicit limit was 20, which could make the index pattern search fail on systems with more than 20 index patterns already existing
  • After the clone DFA tests, also remove the dest index pattern of the cloned job (note, that the DFA clone tests are currently disabled)

@pheyos pheyos self-assigned this Jul 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Jul 29, 2020 •
edited
Loading

Checking test stability in a flaky test runner job ...
=> No failure in 50 runs ✔️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

peteharverson
peteharverson approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 754c353 into elastic:master Jul 29, 2020
@pheyos pheyos deleted the stabilize_dfa_navigation branch July 29, 2020 14:54
@pheyos pheyos mentioned this pull request Jul 29, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Jul 29, 2020
@pheyos
[ML] Functional tests - stabilize DFA navigation and index pattern ha…
0c807b9 
…ndling (elastic#73660)

This PR adds a few stability fixes around DFA creation and cloning.
@pheyos pheyos mentioned this pull request Jul 29, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Jul 29, 2020
@pheyos
[ML] Functional tests - stabilize DFA navigation and index pattern ha…
20358f8 
…ndling (elastic#73660)

This PR adds a few stability fixes around DFA creation and cloning.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
pheyos added a commit that referenced this pull request Jul 30, 2020
@pheyos
[ML] Functional tests - stabilize DFA navigation and index pattern ha…
51f6fdf 
…ndling (#73660) (#73679)

This PR adds a few stability fixes around DFA creation and cloning.
pheyos added a commit that referenced this pull request Jul 30, 2020
@pheyos
[ML] Functional tests - stabilize DFA navigation and index pattern ha…
200fdae 
…ndling (#73660) (#73678)

This PR adds a few stability fixes around DFA creation and cloning.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 30, 2020
@gmmorris
Merge branch 'actions/webhook-remove-header' of github.com:gmmorris/k…
031e0d8 
…ibana into actions/webhook-remove-header

* 'actions/webhook-remove-header' of github.com:gmmorris/kibana: (86 commits)
  [maps] rename GisMap to MapContainer and convert to TS (elastic#73690)
  [APM] docs: remove watcher documentation  (elastic#73485)
  [Maps] fix fit to data for Point to Point layer (elastic#73563)
  [Metrics UI] Fix No Data in Inventory alerts/Snapshot API (elastic#72513)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson