Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] Forms for processors T-U #76710

Merged
merged 5 commits into from
Sep 14, 2020
Merged

[Ingest pipelines] Forms for processors T-U #76710

merged 5 commits into from
Sep 14, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Sep 3, 2020 •
edited
Loading

This PR adds configuration forms for the following processors in the ingest node pipelines UI:

Note: The user_agent processor also has a ecs option. However, per the docs, it has been deprecated, so I did not include it in the form.

Continuation of #72849, #75046, and #75638.

Screenshots

Screen Shot 2020-09-04 at 10 43 31 AM

Screen Shot 2020-09-04 at 10 43 41 AM

Screen Shot 2020-09-04 at 10 43 49 AM

Screen Shot 2020-09-04 at 10 44 32 AM

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Sep 3, 2020
@alisonelizabeth alisonelizabeth force-pushed the ingest_pipelines/processors-t-u branch from b45b1f4 to f14737a Compare September 4, 2020 14:46
@alisonelizabeth alisonelizabeth marked this pull request as ready for review September 4, 2020 15:01
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner September 4, 2020 15:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens
jloleysens approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @alisonelizabeth ! These changes look good to me.

I found one minor issue that would be nice to address here; when adding a user agent processor only a certain subset of fields are allowed. It would be nice to see those listed in the suggestion dropdown of the combobox.

Screenshot 2020-09-07 at 10 47 30

...onents/pipeline_processors_editor/components/manage_processor_form/processors/user_agent.tsx
import { PropertiesField } from './common_fields/properties_field';

const fieldsConfig: FieldsConfig = {
regex_file: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; I try to add an annotation for fields that are required vs optional. Like:

/* Optional fields config */

Above the config for optional fields. Would be nice to add that here too :)

@alisonelizabeth
Copy link
Contributor Author

Thanks @jloleysens for the review!

I found one minor issue that would be nice to address here; when adding a user agent processor only a certain subset of fields are allowed. It would be nice to see those listed in the suggestion dropdown of the combobox.

Good catch. I added support for this.

Screen Shot 2020-09-14 at 9 45 40 AM

Note that a similar issue will occur for the properties field for the geo_ip processor. However, if I'm understanding the docs correctly, the available options will vary depending on what value is set for the database_file field. I left as-is for now (no options), but just wanted to point this out.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ingestPipelines 431 +5 426

async chunks size

id value diff baseline
ingestPipelines 744.4KB +5.1KB 739.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 7dca537 into elastic:master Sep 14, 2020
@alisonelizabeth alisonelizabeth deleted the ingest_pipelines/processors-t-u branch September 14, 2020 15:25
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Sep 14, 2020
@alisonelizabeth
[Ingest pipelines] Forms for processors T-U (elastic#76710)
4f157e9
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 14, 2020
Merged
alisonelizabeth added a commit that referenced this pull request Sep 14, 2020
@alisonelizabeth
[Ingest pipelines] Forms for processors T-U (#76710) (#77364)
c09124c
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 14, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
91ea9c5 
* master: (65 commits)
  [Security Solution][Resolver] Analyzed event styling (elastic#77115)
  filter invalid SOs from the searc hresults in Task Manager (elastic#76891)
  [RUM Dashboard] Visitors by region map (elastic#77135)
  [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555)
  [Ingest pipelines] Forms for processors T-U (elastic#76710)
  updating datatable type (elastic#77320)
  [ML] Fix custom URLs processing for security app (elastic#76957)
  [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747)
  [ML] Transforms: API schemas and integration tests (elastic#75164)
  [Mappings editor] Add support for wildcard field type (elastic#76574)
  [Ingest Manager] Fix flyout instruction selection (elastic#77071)
  [Telemetry Tools] update lodash to 4.17 (elastic#77317)
  [APM] Service inventory redesign (elastic#76744)
  Hide management sections based on cluster/index privileges (elastic#67791)
  [Snapshot Restore] Disable steps when form is invalid (elastic#76540)
  [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824)
  Update apm.ts (elastic#77310)
  [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164)
  [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986)
  [APM] API Snapshot Testing (elastic#77229)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 14, 2020
@gmmorris
Merge branch 'master' into alerts/improve-find-pref
b4729a4 
* master: (65 commits)
  [Security Solution][Resolver] Analyzed event styling (elastic#77115)
  filter invalid SOs from the searc hresults in Task Manager (elastic#76891)
  [RUM Dashboard] Visitors by region map (elastic#77135)
  [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555)
  [Ingest pipelines] Forms for processors T-U (elastic#76710)
  updating datatable type (elastic#77320)
  [ML] Fix custom URLs processing for security app (elastic#76957)
  [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747)
  [ML] Transforms: API schemas and integration tests (elastic#75164)
  [Mappings editor] Add support for wildcard field type (elastic#76574)
  [Ingest Manager] Fix flyout instruction selection (elastic#77071)
  [Telemetry Tools] update lodash to 4.17 (elastic#77317)
  [APM] Service inventory redesign (elastic#76744)
  Hide management sections based on cluster/index privileges (elastic#67791)
  [Snapshot Restore] Disable steps when form is invalid (elastic#76540)
  [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824)
  Update apm.ts (elastic#77310)
  [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164)
  [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986)
  [APM] API Snapshot Testing (elastic#77229)
  ...
@jrodewig jrodewig mentioned this pull request Sep 15, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@yuliacech yuliacech Awaiting requested review from yuliacech

Assignees
No one assigned
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @jloleysens