[RUM Dashboard] Visitors by region map #77135

shahzad31 · 2020-09-10T07:54:34Z

Summary

Added a visitor by region page load duration map

formgeist · 2020-09-10T12:22:25Z

@shahzad31 Would it be possible to add units to the data in the layers panel and possibly apply formats to correctly set the unit?

nreese · 2020-09-10T12:25:06Z

x-pack/plugins/maps/common/descriptor_types/layer_descriptor_types.ts

@@ -28,7 +33,11 @@ export type LayerDescriptor = {
  areLabelsOnTop?: boolean;
  minZoom?: number;
  maxZoom?: number;
-  sourceDescriptor: AbstractSourceDescriptor | null;
+  sourceDescriptor:


The maps plugin exposes a registerSource method, allowing plugins to register custom sources. Prior to custom sources, sourceDescriptor used to be the union of all source descriptor types. Now, the typing only contains the minimum required fields.

Where is this causing typing concerns? Can you cast your sourceDescriptor to add more typing specificity?

reverted this change

elasticmachine · 2020-09-10T12:25:10Z

Pinging @elastic/apm-ui (Team:apm)

x-pack/plugins/maps/public/embeddable/types.ts

justinkambic

This looks awesome. I did have a question whether these geo selection filters are working, they didn't seem to operate correctly when I tried them out. I'm still performing the rest of the code review, but I wanted to get you this feedback in the meantime.

nreese

maps changes LGTM
code review

drewpost · 2020-09-10T18:11:46Z

@shahzad31 on the page load duration view in map, what units am I looking at here? I'd expect to see seconds.

justinkambic

LGTM!

shahzad31 · 2020-09-14T09:41:09Z

@elasticmachine merge upstream

sorenlouv · 2020-09-14T12:12:29Z

x-pack/plugins/apm/public/components/app/RumDashboard/VisitorBreakdownMap/LayerList.ts

+  STYLE_TYPE,
+  SYMBOLIZE_AS_TYPES,
+} from '../../../../../../maps/common/constants';
+import { APM_STATIC_INDEX_PATTERN_ID } from '../../../../../common/apm_index_pattern';


Is it necessary to duplicate this file instead of importing from apm_oss?

sorenlouv · 2020-09-14T12:13:10Z

x-pack/plugins/apm/common/apm_index_pattern.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+export const APM_STATIC_INDEX_PATTERN_ID = 'apm_static_index_pattern_id';


This file already exists in https://github.com/elastic/kibana/blob/master/src/plugins/apm_oss/common/index_pattern_constants.ts. Can we avoid duplicating it?

sorenlouv · 2020-09-14T12:14:11Z

x-pack/plugins/apm/kibana.json

  "requiredBundles": [
    "kibanaReact",
    "kibanaUtils",
    "observability",
-    "home"
+    "home",
+    "maps"


Perhaps add a comment that this is used by csm. This way we can remove it when csm is moved to a separate app.

JSON doesn't have comments.

…o visitor-map

kibanamachine · 2020-09-14T14:35:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 92930d7

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
apm	1249	+10	1239

async chunks size

id	value	diff	baseline
apm	4.9MB	+23.2KB	4.9MB
maps	3.3MB	-2.9KB	3.3MB
total		+20.3KB

page load bundle size

id	value	diff	baseline
apm	42.3KB	+538.0B	41.7KB
maps	300.9KB	+3.1KB	297.8KB
total		+3.7KB

History

💚 Build #74056 succeeded ace12e5
💚 Build #73762 succeeded abbd95b
💚 Build #73662 succeeded 69687d4
💚 Build #73645 succeeded e94d3cb
💔 Build #73635 failed e103c08

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (65 commits) [Security Solution][Resolver] Analyzed event styling (elastic#77115) filter invalid SOs from the searc hresults in Task Manager (elastic#76891) [RUM Dashboard] Visitors by region map (elastic#77135) [Security Solution][Endpoint][Admin] Task/endpoint list actions (elastic#76555) [Ingest pipelines] Forms for processors T-U (elastic#76710) updating datatable type (elastic#77320) [ML] Fix custom URLs processing for security app (elastic#76957) [telemetry] add schema guideline + schema_check new check for --path config (elastic#75747) [ML] Transforms: API schemas and integration tests (elastic#75164) [Mappings editor] Add support for wildcard field type (elastic#76574) [Ingest Manager] Fix flyout instruction selection (elastic#77071) [Telemetry Tools] update lodash to 4.17 (elastic#77317) [APM] Service inventory redesign (elastic#76744) Hide management sections based on cluster/index privileges (elastic#67791) [Snapshot Restore] Disable steps when form is invalid (elastic#76540) [Mappings editor] Add support for positive_score_impact to rank_feature (elastic#76824) Update apm.ts (elastic#77310) [OBS] Remove beta badge, change news feed size and add external icon to news feed link (elastic#77164) [Discover] Convert legacy sort to be compatible with multi sort (elastic#76986) [APM] API Snapshot Testing (elastic#77229) ...

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

shahzad31 added 21 commits September 3, 2020 18:41

update

64bbd06

Merge branch 'master' into visitor-breakdown-usability

8b86367

update

e409714

Merge branch 'master' into visitor-breakdown-usability

48e3009

update

54e8176

Merge branch 'master' into visitor-breakdown-usability

caa2328

update

85549e0

Merge branch 'master' into visitor-breakdown-usability

5e41f85

Merge branch 'master' into visitor-breakdown-usability

e978f57

update

7f7025a

Merge branch 'master' into visitor-breakdown-usability

a9b56b8

WIP

31d7ca5

WIP

1ee8627

added filters to map

529a853

added filters to map

2edd2f2

Merge branch 'master' into visitor-map

fe90084

update

3b6a371

added few tests

e103c08

added a simple story

7d50ad9

added snapshot

e94d3cb

added some constants

69687d4

shahzad31 marked this pull request as ready for review September 10, 2020 12:01

shahzad31 requested review from a team as code owners September 10, 2020 12:01

shahzad31 self-assigned this Sep 10, 2020

shahzad31 added release_note:enhancement v7.10.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 10, 2020

nreese reviewed Sep 10, 2020

View reviewed changes

botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 10, 2020

nreese reviewed Sep 10, 2020

View reviewed changes

x-pack/plugins/maps/public/embeddable/types.ts Outdated Show resolved Hide resolved

justinkambic reviewed Sep 10, 2020

View reviewed changes

remove extra type changes

54a85be

shahzad31 requested a review from nreese September 10, 2020 15:29

hide filter action

abbd95b

nreese approved these changes Sep 10, 2020

View reviewed changes

justinkambic approved these changes Sep 10, 2020

View reviewed changes

sorenlouv mentioned this pull request Sep 11, 2020

[Maps] [APM] Use Maps in APM instead of custom solution #48538

Closed

Merge branch 'master' into visitor-map

ace12e5

sorenlouv reviewed Sep 14, 2020

View reviewed changes

sorenlouv approved these changes Sep 14, 2020

View reviewed changes

shahzad31 added 2 commits September 14, 2020 14:58

remove redundant file

5fa1e09

Merge branch 'visitor-map' of https://github.com/shahzad31/kibana int…

92930d7

…o visitor-map

shahzad31 merged commit dcd119c into elastic:master Sep 14, 2020

shahzad31 deleted the visitor-map branch September 14, 2020 16:22

shahzad31 mentioned this pull request Sep 14, 2020

[7.x] [RUM Dashboard] Visitors by region map (#77135) #77399

Merged

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 14, 2020

[RUM Dashboard] Visitors by region map (elastic#77135)

cd33fdc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RUM Dashboard] Visitors by region map #77135

[RUM Dashboard] Visitors by region map #77135

shahzad31 commented Sep 10, 2020 •

edited

Loading

formgeist commented Sep 10, 2020

nreese Sep 10, 2020 •

edited

Loading

shahzad31 Sep 10, 2020

elasticmachine commented Sep 10, 2020

justinkambic left a comment •

edited

Loading

nreese left a comment

drewpost commented Sep 10, 2020

justinkambic left a comment

shahzad31 commented Sep 14, 2020

sorenlouv Sep 14, 2020

sorenlouv Sep 14, 2020

sorenlouv Sep 14, 2020

smith Sep 16, 2020

kibanamachine commented Sep 14, 2020

[RUM Dashboard] Visitors by region map #77135

[RUM Dashboard] Visitors by region map #77135

Conversation

shahzad31 commented Sep 10, 2020 • edited Loading

Summary

formgeist commented Sep 10, 2020

nreese Sep 10, 2020 • edited Loading

Choose a reason for hiding this comment

shahzad31 Sep 10, 2020

Choose a reason for hiding this comment

elasticmachine commented Sep 10, 2020

justinkambic left a comment • edited Loading

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

drewpost commented Sep 10, 2020

justinkambic left a comment

Choose a reason for hiding this comment

shahzad31 commented Sep 14, 2020

sorenlouv Sep 14, 2020

Choose a reason for hiding this comment

sorenlouv Sep 14, 2020

Choose a reason for hiding this comment

sorenlouv Sep 14, 2020

Choose a reason for hiding this comment

smith Sep 16, 2020

Choose a reason for hiding this comment

kibanamachine commented Sep 14, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

shahzad31 commented Sep 10, 2020 •

edited

Loading

nreese Sep 10, 2020 •

edited

Loading

justinkambic left a comment •

edited

Loading