-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] [APM] Use Maps in APM instead of custom solution #48538
Comments
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/kibana-gis (Team:Geo) |
Moving APM to use the ems-client (as a low-effort change) or use the MapsEmbeddable (as preferred change) will be a prerequisite for having in APM work with on on-prem version of EMS. |
(1) is the ideal scenario, although (2) will be the smallest change that unblocks Kibana from moving EMS to on-prem. |
APM-maps right now separate out the labels. This is an ER in Maps. #35035 |
#69444 implements the "labels on top" which we can use when we switch to the embeddable. |
Instead of spending time migrating the geo maps perhaps we should deprecate aka remove maps from APM since this is being added to CSM in 7.10: #77135 |
I would suggest we think about adding some sort of call out to the user when viewing the RUM service in APM, that the new CSM experience has the map available, especially if we're removing it entirely from the APM RUM view. |
ICYMI I posted a suggested design for linking to the CSM app from APM UI. AFAICT we're enabling the CSM app in the upcoming release cc @drewpost? #77458 (comment) |
@formgeist Great suggestion. Yes, that's correct. The app is going live with 7.10. There will be a name change (most likely to "User Experience" before launch though |
@drewpost Alright, just need to keep this in mind before launch in order to change the copy. Also, if you have any suggestions on how to improve the copy in the call out, feel free to add them here. |
* Closes #48538 by removing the average duration by country custom geo map. * adds link to client side monitoring below the rum charts * removes unused translations * Removes RUM-specific chart for Avg Duration By Browser * Replace link under charts with CallOut above charts with link to Client Side Monitoring * removes api integration tests for avg_duration_by_browser and usused i18n translations * updates to copy in the CSM callout
…#77458) * Closes elastic#48538 by removing the average duration by country custom geo map. * adds link to client side monitoring below the rum charts * removes unused translations * Removes RUM-specific chart for Avg Duration By Browser * Replace link under charts with CallOut above charts with link to Client Side Monitoring * removes api integration tests for avg_duration_by_browser and usused i18n translations * updates to copy in the CSM callout
…#78093) * Closes #48538 by removing the average duration by country custom geo map. * adds link to client side monitoring below the rum charts * removes unused translations * Removes RUM-specific chart for Avg Duration By Browser * Replace link under charts with CallOut above charts with link to Client Side Monitoring * removes api integration tests for avg_duration_by_browser and usused i18n translations * updates to copy in the CSM callout
APM has a custom map implementation.
Consider using the MapsEmbeddable instead for consistent L&F, and reduce duplication of effort. This would be similar to the Maps integration in SIEM and Uptime ([Uptime design] woldmap on monitor details #45561).
The APM implementation also has hardcoded dependencies on EMS-resources (
kibana/x-pack/legacy/plugins/apm/public/components/shared/charts/TransactionCharts/ChoroplethMap/index.tsx
Lines 45 to 48 in 989489e
Instead of migrating the geo maps perhaps we should deprecate aka remove maps from APM since this is being added to CSM in 7.10: [RUM Dashboard] Visitors by region map #77135
The text was updated successfully, but these errors were encountered: