Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] [APM] Use Maps in APM instead of custom solution #48538

Closed
thomasneirynck opened this issue Oct 17, 2019 · 11 comments · Fixed by #77458
Closed

[Maps] [APM] Use Maps in APM instead of custom solution #48538

thomasneirynck opened this issue Oct 17, 2019 · 11 comments · Fixed by #77458
Assignees
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.10.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 17, 2019

APM has a custom map implementation.

  1. Consider using the MapsEmbeddable instead for consistent L&F, and reduce duplication of effort. This would be similar to the Maps integration in SIEM and Uptime ([Uptime design] woldmap on monitor details #45561).

  2. The APM implementation also has hardcoded dependencies on EMS-resources (

    const MAPBOX_STYLE =
    'https://tiles.maps.elastic.co/styles/osm-bright-desaturated/style.json';
    const GEOJSON_SOURCE =
    'https://vector.maps.elastic.co/files/world_countries_v1.geo.json?elastic_tile_service_tos=agree&my_app_name=ems-landing&my_app_version=7.2.0';
    ). We should migrate to using the EMS-client (https://www.npmjs.com/package/@elastic/ems-client), which will remove this hardcoded dependency, and use the catalog service for service discovery.

  3. Instead of migrating the geo maps perhaps we should deprecate aka remove maps from APM since this is being added to CSM in 7.10: [RUM Dashboard] Visitors by region map #77135

@thomasneirynck thomasneirynck added Team:APM All issues that need APM UI Team support [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Oct 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@sorenlouv sorenlouv added [zube]: Impl Backlog technical debt Improvement of the software architecture and operational architecture labels Oct 31, 2019
@thomasneirynck
Copy link
Contributor Author

Moving APM to use the ems-client (as a low-effort change) or use the MapsEmbeddable (as preferred change) will be a prerequisite for having in APM work with on on-prem version of EMS.

cc @jensallen @nickpeihl @jsanz

@thomasneirynck
Copy link
Contributor Author

(1) is the ideal scenario, although (2) will be the smallest change that unblocks Kibana from moving EMS to on-prem.

@sorenlouv sorenlouv changed the title [Maps] [APM] Use Maps in APM [Maps] [APM] Use Maps in APM instead of custom solution May 18, 2020
@thomasneirynck
Copy link
Contributor Author

APM-maps right now separate out the labels. This is an ER in Maps. #35035

@smith
Copy link
Contributor

smith commented Jul 6, 2020

#69444 implements the "labels on top" which we can use when we switch to the embeddable.

@sorenlouv
Copy link
Member

Instead of spending time migrating the geo maps perhaps we should deprecate aka remove maps from APM since this is being added to CSM in 7.10: #77135

@nehaduggal @ogupte @drewpost

@formgeist
Copy link
Contributor

I would suggest we think about adding some sort of call out to the user when viewing the RUM service in APM, that the new CSM experience has the map available, especially if we're removing it entirely from the APM RUM view.

@formgeist
Copy link
Contributor

ICYMI I posted a suggested design for linking to the CSM app from APM UI. AFAICT we're enabling the CSM app in the upcoming release cc @drewpost? #77458 (comment)

@drewpost
Copy link

@formgeist Great suggestion. Yes, that's correct. The app is going live with 7.10. There will be a name change (most likely to "User Experience" before launch though

@formgeist
Copy link
Contributor

@drewpost Alright, just need to keep this in mind before launch in order to change the copy. Also, if you have any suggestions on how to improve the copy in the call out, feel free to add them here.

ogupte added a commit to ogupte/kibana that referenced this issue Sep 18, 2020
ogupte added a commit that referenced this issue Sep 21, 2020
* Closes #48538 by removing the average duration by country custom geo map.

* adds link to client side monitoring below the rum charts

* removes unused translations

* Removes RUM-specific chart for Avg Duration By Browser

* Replace link under charts with CallOut above charts with link to Client Side Monitoring

* removes api integration tests for  avg_duration_by_browser and usused i18n translations

* updates to copy in the CSM callout
ogupte added a commit to ogupte/kibana that referenced this issue Sep 21, 2020
…#77458)

* Closes elastic#48538 by removing the average duration by country custom geo map.

* adds link to client side monitoring below the rum charts

* removes unused translations

* Removes RUM-specific chart for Avg Duration By Browser

* Replace link under charts with CallOut above charts with link to Client Side Monitoring

* removes api integration tests for  avg_duration_by_browser and usused i18n translations

* updates to copy in the CSM callout
ogupte added a commit that referenced this issue Sep 21, 2020
…#78093)

* Closes #48538 by removing the average duration by country custom geo map.

* adds link to client side monitoring below the rum charts

* removes unused translations

* Removes RUM-specific chart for Avg Duration By Browser

* Replace link under charts with CallOut above charts with link to Client Side Monitoring

* removes api integration tests for  avg_duration_by_browser and usused i18n translations

* updates to copy in the CSM callout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants