[APM] Replace custom map with link to Client Side Monitoring #77458

ogupte · 2020-09-15T10:03:57Z

Closes #48538 by replacing the RUM-specific charts (including the custom map for average duration by country) with a callout & link to the client side monitoring app which already displays this data.

elasticmachine · 2020-09-15T10:04:03Z

Pinging @elastic/apm-ui (Team:apm)

nreese · 2020-09-15T16:24:12Z

x-pack/plugins/apm/public/components/shared/Links/ClientSideMonitoringLink.tsx

+  const { basePath } = core.http;
+  const href = basePath.prepend(`/app/csm`);
+
+  return <EuiLink {...props} href={href} />;


Should this use onClick and navigateToUrl to avoid page reload? https://www.elastic.co/guide/en/kibana/master/kibana-navigation.html#navigating-between-kibana-apps

I made this open the CSM app in new tab, which is always a full page load. I'm not totally sure if we should open a new tab, so we could end up going with your suggestion.

We're using the RedirectAppLinks component so if it doesn't open in a new tab it will not cause a page reload.

I'm leaning toward not opening in new tab - but would be good to know if there is a consensus around this in Kibana.

I don't think we should open in a new tab.

sorenlouv · 2020-09-15T18:31:04Z

LGTM. @formgeist any thoughts on the design?

formgeist · 2020-09-16T09:32:00Z

I think we should remove the browser breakdown because this is also available in the new CSM experience. I would add an EuiCallOut instead of a single link that contains a little more information around the new app and what to expect. This is just mock descriptions, but something like this;

The link should not open in a new tab/window.

sorenlouv · 2020-09-16T11:59:05Z

Thanks @formgeist. Agree that browser breakdown should also be taken out as well. Callout looks better 👍

…om geo map.

…nt Side Monitoring

…i18n translations

formgeist

Just some suggested new copy for the callout. We probably should also think about not displaying this message if the CSM app is disabled. Adding to that, we might consider have another callout message for that case, so the user is aware they need to enable it to use it. I'll reach out to the RUM team to clarify.

formgeist · 2020-09-18T07:55:48Z

x-pack/plugins/apm/public/components/app/TransactionOverview/ClientSideMonitoringCallout.tsx

+      <EuiButton href={clientSideMonitoringHref}>
+        {i18n.translate(
+          'xpack.apm.transactionOverview.clientSideMonitoring.linkLabel',
+          { defaultMessage: 'Learn more' }


Suggested change

{ defaultMessage: 'Learn more' }

{ defaultMessage: 'Take me there' }

formgeist · 2020-09-18T08:00:27Z

x-pack/plugins/apm/public/components/app/TransactionOverview/ClientSideMonitoringCallout.tsx

+          'xpack.apm.transactionOverview.clientSideMonitoring.calloutText',
+          {
+            defaultMessage:
+              'We are introducing a new app which contains breakdown information around browser and location by page load.',


Suggested change

'We are introducing a new app which contains breakdown information around browser and location by page load.',

'We are beyond excited to introduce a new experience for analyzing the user experience metrics specifically for your RUM services. It provides insights into the core vitals and visitor breakdown by browser and location. The app is always available in the left sidebar among the other Observability views. ',

formgeist · 2020-09-18T08:00:59Z

x-pack/plugins/apm/public/components/app/TransactionOverview/ClientSideMonitoringCallout.tsx

+      iconType="cheer"
+      title={i18n.translate(
+        'xpack.apm.transactionOverview.clientSideMonitoring.calloutTitle',
+        { defaultMessage: 'New app: Client Side Monitoring' }


Suggested change

{ defaultMessage: 'New app: Client Side Monitoring' }

{ defaultMessage: 'Introducing: Client Side Monitoring' }

ogupte · 2020-09-21T19:04:27Z

@formgeist

We probably should also think about not displaying this message if the CSM app is disabled.

This is not currently possible since APM and CSM are both enabled/disabled with the same config xpack.apm.enabled. If that changes in the future, we can update this callout to display conditionally.

…duration-map-from-rum-view

kibanamachine · 2020-09-21T20:54:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e9c213b

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
apm	1248	-9	1257

async chunks size

id	value	diff	baseline
apm	4.2MB	-801.5KB	5.0MB

distributable file count

id	value	diff	baseline
default	45922	-5	45927

History

💔 Build #75449 failed 684bfc3
💔 Build #75413 failed ee9b5b5
💚 Build #74502 succeeded 7bee08e53cc95b72e3cd2d3d4f15579bf93d9a10
💔 Build #74410 failed 4bd19479f6197c7fd425767b07296d97a9ee67b1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#77458) * Closes elastic#48538 by removing the average duration by country custom geo map. * adds link to client side monitoring below the rum charts * removes unused translations * Removes RUM-specific chart for Avg Duration By Browser * Replace link under charts with CallOut above charts with link to Client Side Monitoring * removes api integration tests for avg_duration_by_browser and usused i18n translations * updates to copy in the CSM callout

…#78093) * Closes #48538 by removing the average duration by country custom geo map. * adds link to client side monitoring below the rum charts * removes unused translations * Removes RUM-specific chart for Avg Duration By Browser * Replace link under charts with CallOut above charts with link to Client Side Monitoring * removes api integration tests for avg_duration_by_browser and usused i18n translations * updates to copy in the CSM callout

ogupte added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 15, 2020

ogupte requested a review from a team as a code owner September 15, 2020 10:03

botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 15, 2020

nreese reviewed Sep 15, 2020

View reviewed changes

sorenlouv approved these changes Sep 15, 2020

View reviewed changes

formgeist mentioned this pull request Sep 16, 2020

[Maps] [APM] Use Maps in APM instead of custom solution #48538

Closed

ogupte added 5 commits September 17, 2020 14:43

Closes elastic#48538 by removing the average duration by country cust…

696005c

…om geo map.

adds link to client side monitoring below the rum charts

ae50151

removes unused translations

0ffe223

Removes RUM-specific chart for Avg Duration By Browser

0c60637

Replace link under charts with CallOut above charts with link to Clie…

ee9b5b5

…nt Side Monitoring

ogupte force-pushed the apm-48538-remove-duration-map-from-rum-view branch from 7bee08e to ee9b5b5 Compare September 18, 2020 00:28

removes api integration tests for avg_duration_by_browser and usused …

684bfc3

…i18n translations

formgeist reviewed Sep 18, 2020

View reviewed changes

ogupte added 2 commits September 21, 2020 12:15

updates to copy in the CSM callout

c3c1ecf

Merge remote-tracking branch 'upstream/master' into apm-48538-remove-…

e9c213b

…duration-map-from-rum-view

ogupte merged commit f015bea into elastic:master Sep 21, 2020

ogupte mentioned this pull request Sep 21, 2020

[7.x] [APM] Replace custom map with link to Client Side Monitoring (#77458) #78093

Merged

formgeist mentioned this pull request Sep 23, 2020

[APM] Update CSM copy to contain the new name User Experience and update link #78207

Closed

This was referenced Nov 16, 2020

GeoIP enrichment processor elastic/apm-server#3613

Closed

aggregation/txmetrics: drop user-agent parsing elastic/apm-server#4439

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Replace custom map with link to Client Side Monitoring #77458

[APM] Replace custom map with link to Client Side Monitoring #77458

ogupte commented Sep 15, 2020 •

edited

Loading

elasticmachine commented Sep 15, 2020

nreese Sep 15, 2020

ogupte Sep 15, 2020

smith Sep 15, 2020

sorenlouv Sep 15, 2020

smith Sep 15, 2020

sorenlouv commented Sep 15, 2020

formgeist commented Sep 16, 2020

sorenlouv commented Sep 16, 2020 •

edited

Loading

formgeist left a comment

formgeist Sep 18, 2020

formgeist Sep 18, 2020

formgeist Sep 18, 2020

ogupte commented Sep 21, 2020

kibanamachine commented Sep 21, 2020

	{ defaultMessage: 'Learn more' }
	{ defaultMessage: 'Take me there' }

	'We are introducing a new app which contains breakdown information around browser and location by page load.',
	'We are beyond excited to introduce a new experience for analyzing the user experience metrics specifically for your RUM services. It provides insights into the core vitals and visitor breakdown by browser and location. The app is always available in the left sidebar among the other Observability views. ',

	{ defaultMessage: 'New app: Client Side Monitoring' }
	{ defaultMessage: 'Introducing: Client Side Monitoring' }

[APM] Replace custom map with link to Client Side Monitoring #77458

[APM] Replace custom map with link to Client Side Monitoring #77458

Conversation

ogupte commented Sep 15, 2020 • edited Loading

elasticmachine commented Sep 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv commented Sep 15, 2020

formgeist commented Sep 16, 2020

sorenlouv commented Sep 16, 2020 • edited Loading

formgeist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogupte commented Sep 21, 2020

kibanamachine commented Sep 21, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

distributable file count

History

ogupte commented Sep 15, 2020 •

edited

Loading

sorenlouv commented Sep 16, 2020 •

edited

Loading