Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy ES plugin #77703

Merged
merged 6 commits into from
Sep 18, 2020
Merged

remove legacy ES plugin #77703

merged 6 commits into from
Sep 18, 2020

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Sep 17, 2020 •
edited
Loading

Summary

Part of #71927

  • remove the legacy ES plugin
  • remove references to src/legacy/core_plugins
  • adapt usages of the legacy ES plugin types

@pgayvallet pgayvallet added Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 labels Sep 17, 2020
@pgayvallet
Copy link
Contributor Author

Blocked by #76054, as the legacy /stats and/or /status API are using the plugin exposed getCluster API.

@pgayvallet pgayvallet marked this pull request as ready for review September 17, 2020 14:06
@pgayvallet pgayvallet requested review from a team as code owners September 17, 2020 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

pgayvallet
pgayvallet commented Sep 17, 2020
View reviewed changes
x-pack/plugins/searchprofiler/server/types.ts
Comment on lines 11 to 13
export interface AppServerPluginDependencies {
licensing: LicensingPluginSetup;
elasticsearch: ElasticsearchPlugin;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually unused, I just removed it from the interface

x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/constants.tsx
Comment on lines -9 to +10

import { DeprecationInfo } from 'src/legacy/core_plugins/elasticsearch';
// eslint-disable-next-line @kbn/eslint/no-restricted-paths
import type { DeprecationInfo } from '../../../../../../../../src/core/server/elasticsearch/legacy/api_types';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a few references to DeprecationInfo in the upgrade_assistant plugin. To avoid exporting additional deprecated types from core, and knowing that the legacy client is deprecated anyway, I used the internal path instead.

watson
watson approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Security changes LGTM 👍

@pgayvallet pgayvallet mentioned this pull request Sep 17, 2020
Merged
3 tasks
afharo
afharo approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM!

(type change in x-pack/plugins/telemetry_collection_xpack/server/telemetry_collection/get_xpack.ts)

walterra
walterra approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML/Transform changes LGTM

cjcenizal
cjcenizal approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup, Search Profiler, and UA code LGTM, didn't test locally.

@pgayvallet pgayvallet requested a review from a team September 17, 2020 17:22
joshdover
joshdover approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tylersmalley
tylersmalley approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops changes look good 👍

poffdeluxe
poffdeluxe approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes lgtm

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

‼️ ERROR: build [6a86d864-412a-4b11-a95b-3d090d1dbdef] is not a valid pull request build

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 3759063 into elastic:master Sep 18, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Sep 18, 2020
@pgayvallet
remove legacy ES plugin (elastic#77703)
d0006f7 
* remove legacy ES plug

* fix types

* delete some `legacy/core_plugins` references

* fix type
# Conflicts:
#	.github/CODEOWNERS
#	src/legacy/core_plugins/elasticsearch/index.js
#	src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.js
#	src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.test.js
#	src/legacy/core_plugins/elasticsearch/lib/cluster.ts
#	src/legacy/core_plugins/elasticsearch/lib/create_proxy.js
#	x-pack/dev-tools/jest/create_jest_config.js
@pgayvallet pgayvallet mentioned this pull request Sep 18, 2020
Merged
pgayvallet added a commit that referenced this pull request Sep 18, 2020
@pgayvallet
[7.x] remove legacy ES plugin (#77703) (#77847)
97e7137 
* remove legacy ES plugin (#77703)

* remove legacy ES plug

* fix types

* delete some `legacy/core_plugins` references

* fix type
# Conflicts:
#	.github/CODEOWNERS
#	src/legacy/core_plugins/elasticsearch/index.js
#	src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.js
#	src/legacy/core_plugins/elasticsearch/lib/abortable_request_handler.test.js
#	src/legacy/core_plugins/elasticsearch/lib/cluster.ts
#	src/legacy/core_plugins/elasticsearch/lib/create_proxy.js
#	x-pack/dev-tools/jest/create_jest_config.js

* remove unused legacy file from 7.x
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
@gmmorris
Merge branch 'master' into task-manager/health
a34dd73 
* master: (92 commits)
  [ILM] Data tiers for 7.10 (elastic#76126)
  [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789)
  [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654)
  Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746)
  [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598)
  [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688)
  fixed react warning in Suspense in alert flyout (elastic#77777)
  [APM] Track usage of Gold+ features (elastic#77630)
  Visualize: Bad request when working with histogram aggregation (elastic#77684)
  remove legacy ES plugin (elastic#77703)
  [Lens] change name of custom query to filters (elastic#77725)
  skip flaky suite (elastic#76239)
  remove visual aspects of baseline job (elastic#77815)
  skip flaky suite (elastic#77835)
  Fixes typo in data recognizer text (elastic#77691)
  management/update trusted_apps jest snapshot
  [build] Use Elastic hosted UBI minimal base image (elastic#77776)
  [APM] Add transaction error rate alert (elastic#76933)
  [Security Solution] [Detections] Remove file validation on import route (elastic#77770)
  [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@joshdover joshdover joshdover approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@walterra walterra walterra approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@watson watson watson approved these changes

Assignees
No one assigned
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@pgayvallet @elasticmachine @kibanamachine @watson @tylersmalley @walterra @poffdeluxe @cjcenizal @joshdover @afharo