Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. #77746

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Sep 17, 2020

Re-enable session lifespan api integration tests.

In this PR I also updated report names for some of our tests (made them unique) as it seems CI's Test Results only picks up tests from the first config with a specific report name. Trying to figure that out with Operations Team, not sure if it's just CI UI glitch or these tests aren't run at all.

Fixes: #76223, #76239

@azasypkin azasypkin added test Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 17, 2020
@azasypkin
Copy link
Member Author

azasypkin commented Sep 17, 2020

Flaky Test Runner Job (42 executions): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/834/

@azasypkin
Copy link
Member Author

Result from https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/834/: 42 runs, 0 failures.

Screenshot from 2020-09-17 20-11-24

@azasypkin azasypkin marked this pull request as ready for review September 17, 2020 18:12
@azasypkin azasypkin requested a review from a team as a code owner September 17, 2020 18:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack APM API integration tests (basic).x-pack/test/apm_api_integration/basic/tests/metrics_charts/metrics_charts·ts.APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: APM specs (basic)
[00:00:00]           └-> "before all" hook
[00:02:09]           └-: Metrics
[00:02:09]             └-> "before all" hook
[00:02:09]             └-: when data is loaded
[00:02:09]               └-> "before all" hook
[00:02:09]               └-> "before all" hook
[00:02:10]                 │ info [metrics_8.0.0] Loading "mappings.json"
[00:02:10]                 │ info [metrics_8.0.0] Loading "data.json.gz"
[00:02:10]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1600412581729425782] [apm-8.0.0-metric-000001] creating index, cause [api], templates [], shards [1]/[0]
[00:02:10]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1600412581729425782] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[apm-8.0.0-metric-000001][0]]])." previous.health="YELLOW" reason="shards started [[apm-8.0.0-metric-000001][0]]"
[00:02:10]                 │ info [metrics_8.0.0] Created index "apm-8.0.0-metric-000001"
[00:02:10]                 │ debg [metrics_8.0.0] "apm-8.0.0-metric-000001" settings {"index":{"codec":"best_compression","lifecycle":{"name":"apm-rollover-30-days","rollover_alias":"apm-8.0.0-metric"},"mapping":{"total_fields":{"limit":"2000"}},"max_docvalue_fields_search":"200","number_of_replicas":"0","number_of_shards":"1","priority":"100","refresh_interval":"1ms"}}
[00:02:11]                 │ info [metrics_8.0.0] Indexed 2323 docs into "apm-8.0.0-metric-000001"
[00:02:11]               └-: for opbeans-node
[00:02:11]                 └-> "before all" hook
[00:02:11]                 └-: returns metrics data
[00:02:11]                   └-> "before all" hook
[00:02:11]                   └-> "before all" hook
[00:02:11]                   └-> contains CPU usage and System memory usage chart data
[00:02:11]                     └-> "before each" hook: global before each
[00:02:11]                     └-> "before each" hook
[00:02:11]                     └- ✓ pass  (1ms) "APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data contains CPU usage and System memory usage chart data"
[00:02:11]                   └-> "after each" hook
[00:02:11]                   └-: CPU usage
[00:02:11]                     └-> "before all" hook
[00:02:11]                     └-> "before all" hook
[00:02:11]                     └-> has correct series
[00:02:11]                       └-> "before each" hook: global before each
[00:02:11]                       └-> "before each" hook
[00:02:11]                       └- ✓ pass  (1ms) "APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series"
[00:02:11]                     └-> "after each" hook
[00:02:11]                     └-> has correct series overall values
[00:02:11]                       └-> "before each" hook: global before each
[00:02:11]                       └-> "before each" hook
[00:02:11]                       └- ✖ fail: APM specs (basic) Metrics when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values
[00:02:11]                       │       Error: expect(received).toMatchInlineSnapshot(snapshot)
[00:02:11]                       │ 
[00:02:11]                       │ Snapshot name: `when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values 1`
[00:02:11]                       │ 
[00:02:11]                       │ - Snapshot  - 1
[00:02:11]                       │ + Received  + 1
[00:02:11]                       │ 
[00:02:11]                       │   Array [
[00:02:11]                       │     0.714,
[00:02:11]                       │ -   0.38770000000000004,
[00:02:11]                       │ +   0.3877,
[00:02:11]                       │     0.75,
[00:02:11]                       │     0.2543,
[00:02:11]                       │   ]
[00:02:11]                       │       + expected - actual
[00:02:11]                       │ 
[00:02:11]                       │       -false
[00:02:11]                       │       +true
[00:02:11]                       │       
[00:02:11]                       │       at Assertion.assert (/dev/shm/workspace/parallel/22/kibana/packages/kbn-expect/expect.js:100:11)
[00:02:11]                       │       at Assertion.toMatchInline [as eql] (/dev/shm/workspace/parallel/22/kibana/packages/kbn-expect/expect.js:244:8)
[00:02:11]                       │       at Context.apply (test/apm_api_integration/basic/tests/metrics_charts/metrics_charts.ts:69:16)
[00:02:11]                       │       at Object.apply (/dev/shm/workspace/parallel/22/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30)
[00:02:11]                       │ 
[00:02:11]                       │ 

Stack Trace

{ Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `when data is loaded for opbeans-node returns metrics data CPU usage has correct series overall values 1`

- Snapshot  - 1
+ Received  + 1

  Array [
    0.714,
-   0.38770000000000004,
+   0.3877,
    0.75,
    0.2543,
  ]
    at Assertion.assert (/dev/shm/workspace/parallel/22/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.toMatchInline [as eql] (/dev/shm/workspace/parallel/22/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.apply (test/apm_api_integration/basic/tests/metrics_charts/metrics_charts.ts:69:16)
    at Object.apply (/dev/shm/workspace/parallel/22/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:30) actual: 'false', expected: 'true', showDiff: true }

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin changed the title Re-enable session lifespan api integration tests. Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. Sep 18, 2020
@azasypkin azasypkin merged commit 9a0dfcf into elastic:master Sep 18, 2020
@azasypkin azasypkin deleted the issue-76223-session-cleanup-test branch September 18, 2020 09:08
@azasypkin
Copy link
Member Author

7.x/7.10.0: 31cb622

gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
* master: (92 commits)
  [ILM] Data tiers for 7.10 (elastic#76126)
  [ML] Transforms: Fixes styling of preview grid pagination in summary step (elastic#77789)
  [Drilldowns] Beta badge support. Mark URL Drilldown as Beta (elastic#75654)
  Re-enable session lifespan, idle timeout api integration tests and use unique names for the security test reports. (elastic#77746)
  [Alerting] renames code in alerting RBAC exemption to make it easier to maintain (elastic#77598)
  [Alerting & Actions] Overwrite SOs when updating instead of partially updating (elastic#73688)
  fixed react warning in Suspense in alert flyout (elastic#77777)
  [APM] Track usage of Gold+ features (elastic#77630)
  Visualize: Bad request when working with histogram aggregation (elastic#77684)
  remove legacy ES plugin (elastic#77703)
  [Lens] change name of custom query to filters (elastic#77725)
  skip flaky suite (elastic#76239)
  remove visual aspects of baseline job (elastic#77815)
  skip flaky suite (elastic#77835)
  Fixes typo in data recognizer text (elastic#77691)
  management/update trusted_apps jest snapshot
  [build] Use Elastic hosted UBI minimal base image (elastic#77776)
  [APM] Add transaction error rate alert (elastic#76933)
  [Security Solution] [Detections] Remove file validation on import route (elastic#77770)
  [Enterprise Search][tech debt] Add Kea logic paths for easier debugging/defaults (elastic#77698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! test v7.10.0 v8.0.0
Projects
None yet
4 participants