Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Error rate on service list page is not in sync with the value at the transaction page #80814

Merged
merged 6 commits into from
Oct 20, 2020

Conversation

cauemarcondes
Copy link
Contributor

closes #80475

Screenshot 2020-10-16 at 13 14 28

Screenshot 2020-10-16 at 13 15 22

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 16, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 16, 2020 11:18
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit 👍

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @dgieselaar's comments. Apart from that 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB -5.0B

distributable file count

id before after diff
default 48035 48036 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 17ccf37 into elastic:master Oct 20, 2020
@cauemarcondes cauemarcondes deleted the apm-error-rate-es branch October 20, 2020 12:32
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 20, 2020
…t the transaction page (elastic#80814)

* fixing error rate

* addressing pr comments

* addressing pr comments

* fixing TS issue

* fixing api test
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 20, 2020
…t the transaction page (elastic#80814)

* fixing error rate

* addressing pr comments

* addressing pr comments

* fixing TS issue

* fixing api test
cauemarcondes added a commit that referenced this pull request Oct 20, 2020
…t the transaction page (#80814) (#81149)

* fixing error rate

* addressing pr comments

* addressing pr comments

* fixing TS issue

* fixing api test
cauemarcondes added a commit that referenced this pull request Oct 20, 2020
…t the transaction page (#80814) (#81148)

* fixing error rate

* addressing pr comments

* addressing pr comments

* fixing TS issue

* fixing api test
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.10.0 v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Error rate on service list page is not in sync with the value at the transaction page
5 participants