Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Detections] Read privileges for dependencies #80852

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

dhurley14
Copy link
Contributor

Summary

remove all privileges on hidden saved object type of alert and change alerting privileges to read when read privileges are set for security solution.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dhurley14 dhurley14 requested review from a team as code owners October 16, 2020 15:38
@dhurley14 dhurley14 self-assigned this Oct 16, 2020
@dhurley14 dhurley14 added Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes review Team:SIEM v7.10.0 v7.11.0 v8.0.0 labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

…privileges to read when read privileges are set for security solution
@dhurley14 dhurley14 force-pushed the remove-hidden-alert-so-type branch from d110d81 to c859646 Compare October 19, 2020 14:45
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #82208 succeeded d110d817b9771180b037e6fb96dd5133005e0302

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally, verified rules/notifications behaved as expected between user roles with all/read/none kibana privileges. LGTM! 👍 Thanks @dhurley14!

@dhurley14 dhurley14 merged commit b1d04df into elastic:master Oct 20, 2020
@dhurley14 dhurley14 deleted the remove-hidden-alert-so-type branch October 20, 2020 13:44
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Oct 20, 2020
…astic#80852)

* remove all privileges on hidden saved object type of alert and change alerting privileges to read when read privileges are set for security solution.
dhurley14 added a commit to dhurley14/kibana that referenced this pull request Oct 20, 2020
…astic#80852)

* remove all privileges on hidden saved object type of alert and change alerting privileges to read when read privileges are set for security solution.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
dhurley14 added a commit that referenced this pull request Oct 20, 2020
…es (#80852) (#81163)

* remove all privileges on hidden saved object type of alert and change alerting privileges to read when read privileges are set for security solution.
dhurley14 added a commit that referenced this pull request Oct 20, 2020
…ies (#80852) (#81164)

* remove all privileges on hidden saved object type of alert and change alerting privileges to read when read privileges are set for security solution.
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes review Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants