[Security Solution][Endpoint][Admin] Malware Protections Notify User Version #81415

parkiino · 2020-10-21T23:11:12Z

Summary

Adds endpoint version number that malware protections user notification checkbox is valid for in policy details

ISSUE: https://github.com/elastic/security-team/issues/337

elasticmachine · 2020-10-21T23:11:15Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-10-21T23:11:15Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

kevinlog · 2020-10-22T11:31:49Z

...s/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx

@@ -189,14 +191,17 @@ export const MalwareProtections = React.memo(() => {
            />
          </h6>
        </EuiTitle>
+        <EuiText color="subdued" size="xs">
+          <i>{`Endpoint versions ${popupVersionsMap.get('malware')}`}</i>


I think this copy should refer to Agent versions over Endpoint. Users in Fleet will upgrade Agents as opposed to just Endpoints.

What are your thoughts @bfishel @caitlinbetz

kevinlog · 2020-10-22T15:21:22Z

...on/public/management/pages/policy/view/policy_forms/protections/popup_options_to_versions.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { i18n } from '@kbn/i18n';


I wonder if we should just have this file be the place we store all of the version information for protections.

We'd eventually add Ransomware and Register as AV. So we could rename this to just be policy_options_to_versions.ts

@paul-tavares @efreeti let me know your thoughts

Agreed @kevinlog 👍

paul-tavares · 2020-10-22T16:30:52Z

...on/public/management/pages/policy/view/policy_forms/protections/popup_options_to_versions.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { i18n } from '@kbn/i18n';


Agreed @kevinlog 👍

paul-tavares · 2020-10-22T16:31:46Z

...on/public/management/pages/policy/view/policy_forms/protections/popup_options_to_versions.ts

+const popupVersions: Array<[string, string]> = [
+  [
+    'malware',
+    i18n.translate('xpack.securitySolution.endpoint.policyDetails.popup.version.7.11', {


I don't see the need to i18n this if all we are going to store the version.

paul-tavares · 2020-10-22T17:32:48Z

...on/public/management/pages/policy/view/policy_forms/protections/popup_options_to_versions.ts

+  ],
+];
+
+export const popupVersionsMap = new Map<string, string>(popupVersions);


add typing so that Map is set to readonly`

Suggested change

export const popupVersionsMap = new Map<string, string>(popupVersions);

export const popupVersionsMap: ReadonlyMap<string, string> = new Map(popupVersions);

paul-tavares · 2020-10-22T17:42:33Z

...s/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx

@@ -189,14 +191,17 @@ export const MalwareProtections = React.memo(() => {
            />
          </h6>
        </EuiTitle>
+        <EuiText color="subdued" size="xs">


The question longer term would be: should we add this block of JSX manually to every new policy field or have it abstracted behind a component that will determine whether it should be shown or not just by the near existance of that prop name in the "field-to-version" map file.

Here is what I mean:
We could use a component like this:

const SupportedVersionNotice = ({optionName}) => { const version = popupVersionsMap.get(optionName); if (!version) { return null; } return <EuiText color="subdued" size="xs"> <FormattedMessage id="...." defaultMessage="Endpoint versions {version}" values={{ version }} /> </EuiText> }

using it:

<SupportedVersionNotice optionName="malware" />

And if we ever removed this options from the translation map file, then the text in the UI would just "magically" go way :)

Just an idea.

oh that sounds like a noice idea. i can do that

paul-tavares · 2020-10-22T17:42:57Z

...s/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx

@@ -189,14 +191,17 @@ export const MalwareProtections = React.memo(() => {
            />
          </h6>
        </EuiTitle>
+        <EuiText color="subdued" size="xs">
+          <i>{`Endpoint versions ${popupVersionsMap.get('malware')}`}</i>


this needs to be i18n'd (I think maybe you had this in the map file at one point, then moved it here)

yeah okie that makes sense

…fication-version

paul-tavares

🔥 🚀 🚢

kibanamachine · 2020-10-26T20:52:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ce30cdc

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`securitySolution`	2062	2063	+1

async chunks size

id	before	after	diff
`securitySolution`	8.1MB	8.1MB	+915.0B

History

💚 Build #83687 succeeded 9644f13
💚 Build #83233 succeeded d17f05a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) [Lens] Fix URL query loss on redirect (elastic#81475) Log reason for 404 in field existence check (elastic#81315)

* master: (87 commits) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778) [i18n] add get_kibana_translation_paths tests (elastic#81624) [UX] Fix search term reset from url (elastic#81654) [Lens] Improved range formatter (elastic#80132) [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077) [Time to Visualize] Update Library Text with Call to Action (elastic#81667) [docs] Resolving failed Kibana upgrade migrations (elastic#80999) [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709) [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868) Doc changes for stack management and grouped feature privileges (elastic#80486) Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422) [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) ...

kibanamachine · 2020-10-28T17:04:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…Version (#81415) (#81825) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

malware protections notify user versioning

d17f05a

parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.11.0 labels Oct 21, 2020

parkiino requested review from a team as code owners October 21, 2020 23:11

kevinlog reviewed Oct 22, 2020

View reviewed changes

paul-tavares reviewed Oct 22, 2020

View reviewed changes

parkiino added 2 commits October 26, 2020 10:20

Merge remote-tracking branch 'upstream/master' into task/malware-noti…

8fb2a9f

…fication-version

new component for popup version

9644f13

paul-tavares approved these changes Oct 26, 2020

View reviewed changes

change endpoint to agent text

ce30cdc

kevinlog approved these changes Oct 26, 2020

View reviewed changes

parkiino merged commit 8c07eb9 into elastic:master Oct 27, 2020

parkiino deleted the task/malware-notification-version branch October 27, 2020 13:58

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020

parkiino mentioned this pull request Oct 27, 2020

[7.x] [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (#81415) #81825

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2020

parkiino added a commit that referenced this pull request Oct 28, 2020

[Security Solution][Endpoint][Admin] Malware Protections Notify User …

c45518a

…Version (#81415) (#81825) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint][Admin] Malware Protections Notify User Version #81415

[Security Solution][Endpoint][Admin] Malware Protections Notify User Version #81415

parkiino commented Oct 21, 2020 •

edited

Loading

elasticmachine commented Oct 21, 2020

elasticmachine commented Oct 21, 2020

kevinlog Oct 22, 2020

kevinlog Oct 22, 2020

paul-tavares Oct 22, 2020

paul-tavares Oct 22, 2020

paul-tavares Oct 22, 2020

paul-tavares Oct 22, 2020

paul-tavares Oct 22, 2020

parkiino Oct 22, 2020

paul-tavares Oct 22, 2020

parkiino Oct 22, 2020

paul-tavares left a comment

kibanamachine commented Oct 26, 2020

kibanamachine commented Oct 28, 2020

	export const popupVersionsMap = new Map<string, string>(popupVersions);
	export const popupVersionsMap: ReadonlyMap<string, string> = new Map(popupVersions);

[Security Solution][Endpoint][Admin] Malware Protections Notify User Version #81415

[Security Solution][Endpoint][Admin] Malware Protections Notify User Version #81415

Conversation

parkiino commented Oct 21, 2020 • edited Loading

Summary

elasticmachine commented Oct 21, 2020

elasticmachine commented Oct 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 26, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

kibanamachine commented Oct 28, 2020

parkiino commented Oct 21, 2020 •

edited

Loading