Merge branch 'master' into task-manager/lost-connectivity

* master: (87 commits) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778) [i18n] add get_kibana_translation_paths tests (elastic#81624) [UX] Fix search term reset from url (elastic#81654) [Lens] Improved range formatter (elastic#80132) [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077) [Time to Visualize] Update Library Text with Call to Action (elastic#81667) [docs] Resolving failed Kibana upgrade migrations (elastic#80999) [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709) [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868) Doc changes for stack management and grouped feature privileges (elastic#80486) Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422) [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) ...
gmmorris · Oct 27, 2020 · f4886bd · f4886bd
2 parents b18991e + 8b1ff4c
commit f4886bd
Show file tree

Hide file tree

Showing 945 changed files with 17,044 additions and 6,404 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -381,8 +381,9 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
 **/*.scss  @elastic/kibana-design
 #CC# /packages/kbn-ui-framework/ @elastic/kibana-design
 
-# Core design
+# Core UI design
 /src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
+/src/plugins/embeddable/**/*.scss @elastic/kibana-core-ui-designers
 /x-pack/plugins/canvas/**/*.scss @elastic/kibana-core-ui-designers
 /x-pack/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
 /x-pack/plugins/security/**/*.scss @elastic/kibana-core-ui-designers

diff --git a/.github/ISSUE_TEMPLATE/Bug_report_security_solution.md b/.github/ISSUE_TEMPLATE/Bug_report_security_solution.md
@@ -1,38 +1,38 @@
----
-name: Bug report for Security Solution
-about: Help us identify bugs in Elastic Security, SIEM, and Endpoint so we can fix them!
-title: '[Security Solution]'
-labels: 'Team: SecuritySolution'
----
-
-**Describe the bug:**
-
-**Kibana/Elasticsearch Stack version:**
-
-**Server OS version:**
-
-**Browser and Browser OS versions:**
-
-**Elastic Endpoint version:**
-
-**Original install method (e.g. download page, yum, from source, etc.):**
-
-**Functional Area (e.g. Endpoint management, timelines, resolver, etc.):**
-
-**Steps to reproduce:**
-
-1.
-2.
-3.
-
-**Current behavior:**
-
-**Expected behavior:**
-
-**Screenshots (if relevant):**
-
-**Errors in browser console (if relevant):**
-
-**Provide logs and/or server output (if relevant):**
-
-**Any additional context (logs, chat logs, magical formulas, etc.):**
+---
+name: Bug report for Security Solution
+about: Help us identify bugs in Elastic Security, SIEM, and Endpoint so we can fix them!
+title: '[Security Solution]'
+labels: 'bug, Team: SecuritySolution'
+---
+
+**Describe the bug:**
+
+**Kibana/Elasticsearch Stack version:**
+
+**Server OS version:**
+
+**Browser and Browser OS versions:**
+
+**Elastic Endpoint version:**
+
+**Original install method (e.g. download page, yum, from source, etc.):**
+
+**Functional Area (e.g. Endpoint management, timelines, resolver, etc.):**
+
+**Steps to reproduce:**
+
+1.
+2.
+3.
+
+**Current behavior:**
+
+**Expected behavior:**
+
+**Screenshots (if relevant):**
+
+**Errors in browser console (if relevant):**
+
+**Provide logs and/or server output (if relevant):**
+
+**Any additional context (logs, chat logs, magical formulas, etc.):**
diff --git a/.github/ISSUE_TEMPLATE/v8_breaking_change.md b/.github/ISSUE_TEMPLATE/v8_breaking_change.md
@@ -2,7 +2,7 @@
 name: 8.0 Breaking change
 about: Breaking changes from 7.x -> 8.0
 title: "[Breaking change]"
-labels: Team:Elasticsearch UI, Feature:Upgrade Assistant
+labels: Team:Elasticsearch UI, Feature:Upgrade Assistant, Breaking Change
 assignees: ''
 
 ---
@@ -11,15 +11,16 @@ assignees: ''
 
 **Which release will ship the breaking change?**
 
-<!-- e.g., v7.6.2 -->
+8.0
 
 **Describe the change. How will it manifest to users?**
 
-**What percentage of users will be affected?**
+**How many users will be affected?**
 
-<!-- e.g., Roughly 75% will need to make changes to x. -->
+<!-- e.g., Based on telemetry data, roughly 75% of our users will need to make changes to x -->
+<!-- e.g., A majority of users will need to make changes to x. -->
 
-**What can users to do to address the change manually?**
+**What can users do to address the change manually?**
 
 <!-- If applicable, describe the manual workaround -->
 

diff --git a/.telemetryrc.json b/.telemetryrc.json
@@ -7,5 +7,10 @@
       "src/plugins/testbed/",
       "src/plugins/kibana_utils/"
     ]
+  },
+  {
+    "output": "src/plugins/telemetry/schema/legacy_plugins.json",
+    "root": "src/legacy/server/",
+    "exclude": []
   }
 ]
diff --git a/docs/apm/images/advanced-discover.png b/docs/apm/images/advanced-discover.png
diff --git a/docs/apm/troubleshooting.asciidoc b/docs/apm/troubleshooting.asciidoc
@@ -157,7 +157,7 @@ the values in `http.request.cookies` are not indexed and thus not searchable.
 
 *Ensure an index pattern exists*
 As a first step, you should ensure the correct index pattern exists.
-In Kibana, navigate to *Management > Kibana > Index Patterns*.
+Open the main menu, then click *Stack Management > Index Patterns*.
 In the pattern list, you should see an apm index pattern; The default is `apm-*`.
 If you don't, the index pattern doesn't exist. See <<no-apm-data-found>> for information on how to fix this problem.
 

diff --git a/docs/canvas/canvas-tutorial.asciidoc b/docs/canvas/canvas-tutorial.asciidoc
@@ -14,7 +14,7 @@ For this tutorial, you'll need to add the <<add-sample-data, Sample eCommerce or
 
 Your first step to working with Canvas is to create a workpad.
 
-. Open the menu, then go to *Canvas*.
+. Open the main menu, then click *Canvas*.
 
 . On the *Canvas workpads* page, click *Create workpad*.
 

diff --git a/docs/dev-tools/console/console.asciidoc b/docs/dev-tools/console/console.asciidoc
@@ -7,7 +7,7 @@ Console enables you to interact with the REST API of {es}. You can:
 * View API documentation
 * Get your request history
 
-To get started, open the menu, go to *Dev Tools*, then click *Console*.
+To get started, open the main menu, click *Dev Tools*, then click *Console*.
 
 [role="screenshot"]
 image::dev-tools/console/images/console.png["Console"]

diff --git a/docs/dev-tools/grokdebugger/index.asciidoc b/docs/dev-tools/grokdebugger/index.asciidoc
@@ -35,7 +35,7 @@ is automatically enabled in {kib}.
 NOTE: If you're using {stack-security-features}, you must have the `manage_pipeline`
 permission to use the Grok Debugger.
 
-. Open the menu, go to *Dev Tools*, then click *Grok Debugger*.
+. Open the main menu, click *Dev Tools*, then click *Grok Debugger*.
 . In *Sample Data*, enter a message that is representative of the data that you
 want to parse. For example:
 +

diff --git a/docs/dev-tools/painlesslab/index.asciidoc b/docs/dev-tools/painlesslab/index.asciidoc
@@ -12,6 +12,6 @@ process {ref}/docs-reindex.html[reindexed data], define complex
 <<watcher-create-advanced-watch, Watcher conditions>>,
 and work with data in other contexts.
 
-To get started, open the menu, go to *Dev Tools*, then click *Painless Lab*.
+To get started, open the main menu, click *Dev Tools*, then click *Painless Lab*.
 
 image::dev-tools/painlesslab/images/painless-lab.png[Painless Lab]
diff --git a/docs/dev-tools/searchprofiler/getting-started.asciidoc b/docs/dev-tools/searchprofiler/getting-started.asciidoc
@@ -2,7 +2,7 @@
 [[profiler-getting-started]]
 === Getting Started
 
-The {searchprofiler} is automatically enabled in {kib}. From the menu, go to *Dev Tools*, then click *Search Profiler*
+The {searchprofiler} is automatically enabled in {kib}. Open the main menu, click *Dev Tools*, then click *Search Profiler*
 to get started.
 
 {searchprofiler} displays the names of the indices searched, the shards in each index,

diff --git a/...ns/data/public/kibana-plugin-plugins-data-public.painlesserror._constructor_.md b/...ns/data/public/kibana-plugin-plugins-data-public.painlesserror._constructor_.md
@@ -9,13 +9,13 @@ Constructs a new instance of the `PainlessError` class
 <b>Signature:</b>
 
 ```typescript
-constructor(err: EsError, request: IKibanaSearchRequest);
+constructor(err: IEsError, request: IKibanaSearchRequest);
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  err | <code>EsError</code> |  |
+|  err | <code>IEsError</code> |  |
 |  request | <code>IKibanaSearchRequest</code> |  |
 
diff --git a/...elopment/plugins/data/public/kibana-plugin-plugins-data-public.painlesserror.md b/...elopment/plugins/data/public/kibana-plugin-plugins-data-public.painlesserror.md
@@ -7,7 +7,7 @@
 <b>Signature:</b>
 
 ```typescript
-export declare class PainlessError extends KbnError 
+export declare class PainlessError extends EsError 
 ```
 
 ## Constructors

diff --git a/.../server/kibana-plugin-plugins-data-server.indexpatternsfetcher._constructor_.md b/.../server/kibana-plugin-plugins-data-server.indexpatternsfetcher._constructor_.md
@@ -9,12 +9,13 @@ Constructs a new instance of the `IndexPatternsFetcher` class
 <b>Signature:</b>
 
 ```typescript
-constructor(callDataCluster: LegacyAPICaller);
+constructor(elasticsearchClient: ElasticsearchClient, allowNoIndices?: boolean);
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  callDataCluster | <code>LegacyAPICaller</code> |  |
+|  elasticsearchClient | <code>ElasticsearchClient</code> |  |
+|  allowNoIndices | <code>boolean</code> |  |
 
diff --git a/.../kibana-plugin-plugins-data-server.indexpatternsfetcher.getfieldsforwildcard.md b/.../kibana-plugin-plugins-data-server.indexpatternsfetcher.getfieldsforwildcard.md
@@ -13,7 +13,7 @@ getFieldsForWildcard(options: {
         pattern: string | string[];
         metaFields?: string[];
         fieldCapsOptions?: {
-            allowNoIndices: boolean;
+            allow_no_indices: boolean;
         };
     }): Promise<FieldDescriptor[]>;
 ```
@@ -22,7 +22,7 @@ getFieldsForWildcard(options: {
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  options | <code>{</code><br/><code>        pattern: string &#124; string[];</code><br/><code>        metaFields?: string[];</code><br/><code>        fieldCapsOptions?: {</code><br/><code>            allowNoIndices: boolean;</code><br/><code>        };</code><br/><code>    }</code> |  |
+|  options | <code>{</code><br/><code>        pattern: string &#124; string[];</code><br/><code>        metaFields?: string[];</code><br/><code>        fieldCapsOptions?: {</code><br/><code>            allow_no_indices: boolean;</code><br/><code>        };</code><br/><code>    }</code> |  |
 
 <b>Returns:</b>
 

diff --git a/...t/plugins/data/server/kibana-plugin-plugins-data-server.indexpatternsfetcher.md b/...t/plugins/data/server/kibana-plugin-plugins-data-server.indexpatternsfetcher.md
@@ -14,7 +14,7 @@ export declare class IndexPatternsFetcher
 
 |  Constructor | Modifiers | Description |
 |  --- | --- | --- |
-|  [(constructor)(callDataCluster)](./kibana-plugin-plugins-data-server.indexpatternsfetcher._constructor_.md) |  | Constructs a new instance of the <code>IndexPatternsFetcher</code> class |
+|  [(constructor)(elasticsearchClient, allowNoIndices)](./kibana-plugin-plugins-data-server.indexpatternsfetcher._constructor_.md) |  | Constructs a new instance of the <code>IndexPatternsFetcher</code> class |
 
 ## Methods
 

diff --git a/...ions/public/kibana-plugin-plugins-expressions-public.execution._constructor_.md b/...ions/public/kibana-plugin-plugins-expressions-public.execution._constructor_.md
@@ -9,12 +9,12 @@ Constructs a new instance of the `Execution` class
 <b>Signature:</b>
 
 ```typescript
-constructor(params: ExecutionParams<ExtraContext>);
+constructor(execution: ExecutionParams);
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
-|  params | <code>ExecutionParams&lt;ExtraContext&gt;</code> |  |
+|  execution | <code>ExecutionParams</code> |  |
 
diff --git a/...xpressions/public/kibana-plugin-plugins-expressions-public.execution.context.md b/...xpressions/public/kibana-plugin-plugins-expressions-public.execution.context.md
@@ -9,5 +9,5 @@ Execution context - object that allows to do side-effects. Context is passed to
 <b>Signature:</b>
 
 ```typescript
-readonly context: ExecutionContext<Input, InspectorAdapters> & ExtraContext;
+readonly context: ExecutionContext<InspectorAdapters>;
 ```
diff --git a/...pressions/public/kibana-plugin-plugins-expressions-public.execution.contract.md b/...pressions/public/kibana-plugin-plugins-expressions-public.execution.contract.md
@@ -9,5 +9,5 @@ Contract is a public representation of `Execution` instances. Contract we can re
 <b>Signature:</b>
 
 ```typescript
-readonly contract: ExecutionContract<ExtraContext, Input, Output, InspectorAdapters>;
+readonly contract: ExecutionContract<Input, Output, InspectorAdapters>;
 ```
diff --git a/...ns-expressions-public.execution.params.md → ...expressions-public.execution.execution.md b/...ns-expressions-public.execution.params.md → ...expressions-public.execution.execution.md
@@ -1,11 +1,11 @@
 <!-- Do not edit this file. It is automatically generated by API Documenter. -->
 
-[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [Execution](./kibana-plugin-plugins-expressions-public.execution.md) &gt; [params](./kibana-plugin-plugins-expressions-public.execution.params.md)
+[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [Execution](./kibana-plugin-plugins-expressions-public.execution.md) &gt; [execution](./kibana-plugin-plugins-expressions-public.execution.execution.md)
 
-## Execution.params property
+## Execution.execution property
 
 <b>Signature:</b>
 
 ```typescript
-readonly params: ExecutionParams<ExtraContext>;
+readonly execution: ExecutionParams;
 ```
diff --git a/...ressions/public/kibana-plugin-plugins-expressions-public.execution.interpret.md b/...ressions/public/kibana-plugin-plugins-expressions-public.execution.interpret.md
@@ -7,7 +7,7 @@
 <b>Signature:</b>
 
 ```typescript
-interpret<T>(ast: ExpressionAstNode, input: T, options?: ExpressionExecOptions): Promise<unknown>;
+interpret<T>(ast: ExpressionAstNode, input: T): Promise<unknown>;
 ```
 
 ## Parameters
@@ -16,7 +16,6 @@ interpret<T>(ast: ExpressionAstNode, input: T, options?: ExpressionExecOptions):
 |  --- | --- | --- |
 |  ast | <code>ExpressionAstNode</code> |  |
 |  input | <code>T</code> |  |
-|  options | <code>ExpressionExecOptions</code> |  |
 
 <b>Returns:</b>
 

diff --git a/...lugins/expressions/public/kibana-plugin-plugins-expressions-public.execution.md b/...lugins/expressions/public/kibana-plugin-plugins-expressions-public.execution.md
@@ -7,25 +7,25 @@
 <b>Signature:</b>
 
 ```typescript
-export declare class Execution<ExtraContext extends Record<string, unknown> = Record<string, unknown>, Input = unknown, Output = unknown, InspectorAdapters extends Adapters = ExtraContext['inspectorAdapters'] extends object ? ExtraContext['inspectorAdapters'] : DefaultInspectorAdapters> 
+export declare class Execution<Input = unknown, Output = unknown, InspectorAdapters extends Adapters = ExpressionExecutionParams['inspectorAdapters'] extends object ? ExpressionExecutionParams['inspectorAdapters'] : DefaultInspectorAdapters> 
 ```
 
 ## Constructors
 
 |  Constructor | Modifiers | Description |
 |  --- | --- | --- |
-|  [(constructor)(params)](./kibana-plugin-plugins-expressions-public.execution._constructor_.md) |  | Constructs a new instance of the <code>Execution</code> class |
+|  [(constructor)(execution)](./kibana-plugin-plugins-expressions-public.execution._constructor_.md) |  | Constructs a new instance of the <code>Execution</code> class |
 
 ## Properties
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
-|  [context](./kibana-plugin-plugins-expressions-public.execution.context.md) |  | <code>ExecutionContext&lt;Input, InspectorAdapters&gt; &amp; ExtraContext</code> | Execution context - object that allows to do side-effects. Context is passed to every function. |
-|  [contract](./kibana-plugin-plugins-expressions-public.execution.contract.md) |  | <code>ExecutionContract&lt;ExtraContext, Input, Output, InspectorAdapters&gt;</code> | Contract is a public representation of <code>Execution</code> instances. Contract we can return to other plugins for their consumption. |
+|  [context](./kibana-plugin-plugins-expressions-public.execution.context.md) |  | <code>ExecutionContext&lt;InspectorAdapters&gt;</code> | Execution context - object that allows to do side-effects. Context is passed to every function. |
+|  [contract](./kibana-plugin-plugins-expressions-public.execution.contract.md) |  | <code>ExecutionContract&lt;Input, Output, InspectorAdapters&gt;</code> | Contract is a public representation of <code>Execution</code> instances. Contract we can return to other plugins for their consumption. |
+|  [execution](./kibana-plugin-plugins-expressions-public.execution.execution.md) |  | <code>ExecutionParams</code> |  |
 |  [expression](./kibana-plugin-plugins-expressions-public.execution.expression.md) |  | <code>string</code> |  |
 |  [input](./kibana-plugin-plugins-expressions-public.execution.input.md) |  | <code>Input</code> | Initial input of the execution.<!-- -->N.B. It is initialized to <code>null</code> rather than <code>undefined</code> for legacy reasons, because in legacy interpreter it was set to <code>null</code> by default. |
 |  [inspectorAdapters](./kibana-plugin-plugins-expressions-public.execution.inspectoradapters.md) |  | <code>InspectorAdapters</code> |  |
-|  [params](./kibana-plugin-plugins-expressions-public.execution.params.md) |  | <code>ExecutionParams&lt;ExtraContext&gt;</code> |  |
 |  [result](./kibana-plugin-plugins-expressions-public.execution.result.md) |  | <code>Promise&lt;Output &#124; ExpressionValueError&gt;</code> |  |
 |  [state](./kibana-plugin-plugins-expressions-public.execution.state.md) |  | <code>ExecutionContainer&lt;Output &#124; ExpressionValueError&gt;</code> | Dynamic state of the execution. |
 
@@ -35,7 +35,7 @@ export declare class Execution<ExtraContext extends Record<string, unknown> = Re
 |  --- | --- | --- |
 |  [cancel()](./kibana-plugin-plugins-expressions-public.execution.cancel.md) |  | Stop execution of expression. |
 |  [cast(value, toTypeNames)](./kibana-plugin-plugins-expressions-public.execution.cast.md) |  |  |
-|  [interpret(ast, input, options)](./kibana-plugin-plugins-expressions-public.execution.interpret.md) |  |  |
+|  [interpret(ast, input)](./kibana-plugin-plugins-expressions-public.execution.interpret.md) |  |  |
 |  [invokeChain(chainArr, input)](./kibana-plugin-plugins-expressions-public.execution.invokechain.md) |  |  |
 |  [invokeFunction(fn, input, args)](./kibana-plugin-plugins-expressions-public.execution.invokefunction.md) |  |  |
 |  [resolveArgs(fnDef, input, argAsts)](./kibana-plugin-plugins-expressions-public.execution.resolveargs.md) |  |  |

diff --git a/...ublic.executioncontext.getinitialinput.md → ...blic.executioncontext.getsearchcontext.md b/...ublic.executioncontext.getinitialinput.md → ...blic.executioncontext.getsearchcontext.md
@@ -1,13 +1,13 @@
 <!-- Do not edit this file. It is automatically generated by API Documenter. -->
 
-[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [ExecutionContext](./kibana-plugin-plugins-expressions-public.executioncontext.md) &gt; [getInitialInput](./kibana-plugin-plugins-expressions-public.executioncontext.getinitialinput.md)
+[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [ExecutionContext](./kibana-plugin-plugins-expressions-public.executioncontext.md) &gt; [getSearchContext](./kibana-plugin-plugins-expressions-public.executioncontext.getsearchcontext.md)
 
-## ExecutionContext.getInitialInput property
+## ExecutionContext.getSearchContext property
 
-Get initial input with which execution started.
+Get search context of the expression.
 
 <b>Signature:</b>
 
 ```typescript
-getInitialInput: () => Input;
+getSearchContext: () => ExecutionContextSearch;
 ```
diff --git a/...essions-public.executioncontext.search.md → ...ic.executioncontext.getsearchsessionid.md b/...essions-public.executioncontext.search.md → ...ic.executioncontext.getsearchsessionid.md
@@ -1,13 +1,13 @@
 <!-- Do not edit this file. It is automatically generated by API Documenter. -->
 
-[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [ExecutionContext](./kibana-plugin-plugins-expressions-public.executioncontext.md) &gt; [search](./kibana-plugin-plugins-expressions-public.executioncontext.search.md)
+[Home](./index.md) &gt; [kibana-plugin-plugins-expressions-public](./kibana-plugin-plugins-expressions-public.md) &gt; [ExecutionContext](./kibana-plugin-plugins-expressions-public.executioncontext.md) &gt; [getSearchSessionId](./kibana-plugin-plugins-expressions-public.executioncontext.getsearchsessionid.md)
 
-## ExecutionContext.search property
+## ExecutionContext.getSearchSessionId property
 
 Search context in which expression should operate.
 
 <b>Signature:</b>
 
 ```typescript
-search?: ExecutionContextSearch;
+getSearchSessionId: () => string | undefined;
 ```