Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Test creating|copying a policy create a correct POLICY_CHANGE action #81661

Conversation

nchaulet
Copy link
Member

Description

Add missing tests for #81236, Resolve #81623

Ensure when we create or copy a policy a correct POLICY_CHANGE action is created

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Oct 26, 2020
@nchaulet nchaulet self-assigned this Oct 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet force-pushed the feature-test-agent-policy-policy-change-action branch from 26b72ec to 9367cbc Compare October 26, 2020 19:08
@jen-huang jen-huang self-requested a review October 27, 2020 20:20
@nchaulet nchaulet requested review from a team and removed request for a team October 27, 2020 20:53
@nchaulet nchaulet requested a review from jen-huang October 28, 2020 13:50
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It would be good to add additional tests for when an existing agent policy (or its package policies) is updated. Can be done in another PR if you agree.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Test agent config modification side effects
4 participants