-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix POLICY_CHANGE action creation for new policy #81236
[Fleet] Fix POLICY_CHANGE action creation for new policy #81236
Conversation
Pinging @elastic/ingest-management (Team:Ingest Management) |
Can we add some more assertions in the complete agent flow integration test (or some other test suite) to account for the changes here and in #81041? Can be done in a follow up PR. |
Yes it will make sense to add more tests to cover all the side effect of creating/updating an agent config for agent action I will work on it in a follow up PR |
@nchaulet I'd love to partake in any async discussions on what we need to cover here, and where you want to (Kibana FTR or the e2e-testing framework which found the bug for us, we just didn't recognize it as a new error very quickly since we have other bugs currently making noise in the test) - let me know if you want to chat, and I'd love to see what we come up with |
@EricDavisX I will be happy to talk with you on how to test this, |
875f19b
to
16be7a6
Compare
16be7a6
to
3096a06
Compare
…ange-action-creation-new-policy
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
Thank you Nicolas. I have opened this to track initial discussion (and further automation if we use the e2e-testing framework) - elastic/e2e-testing#380 |
Summary
Resolve #81214
the POLICY_CHANGE action (the policy that is distributed to the agent) was not correctly created for new agent action,
This PR fix that.
How to reproduce the bug