Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add link for monitoring ssl settings #81057

Merged
merged 3 commits into from
Oct 21, 2020
Merged

[DOCS] Add link for monitoring ssl settings #81057

merged 3 commits into from
Oct 21, 2020

Conversation

chrisronline
Copy link
Contributor

Resolves #80653

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes docs v7.11.0 labels Oct 19, 2020
@chrisronline chrisronline self-assigned this Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline requested review from lcawl and a team October 19, 2020 19:49
igoristic
igoristic approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so long as https://github.com/elastic/kibana/pull/81057/files#r508035628 is considered

@chrisronline @lcawl
Update docs/settings/monitoring-settings.asciidoc
5e09705 
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl
lcawl approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrisronline @KOTungseth
Update docs/settings/monitoring-settings.asciidoc
27f2652 
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@chrisronline chrisronline merged commit b87401a into elastic:master Oct 21, 2020
@chrisronline chrisronline deleted the monitoring/ssl_docs branch October 21, 2020 14:32
This was referenced Oct 21, 2020
Merged
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Oct 21, 2020
@chrisronline @lcawl @KOTungseth
[DOCS] Add link for monitoring ssl settings (elastic#81057)
c6a4276 
* Add link for ssl settings

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 21, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/migrate-w…
805a55d 
…arm-phase-to-formlib

* 'master' of github.com:elastic/kibana: (55 commits)
  [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106)
  [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082)
  [DOCS] Add link for monitoring ssl settings (elastic#81057)
  [test] Await loading indicator in monitoring test (elastic#81279)
  [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512)
  [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287)
  [Discover] Deangularize context.app (elastic#80851)
  [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873)
  [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671)
  Fix tagcloud word overlapping (elastic#81161)
  [Security Solution] Fixes flaky test rules (elastic#81040)
  Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183)
  [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301)
  Add namespaced version of the API call (elastic#81278)
  [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123)
  [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236)
  [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084)
  [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239)
  skip flaky suite (elastic#81264)
  [Maps] fix top-level Map page is called 'Kibana' (elastic#81238)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

chrisronline added a commit that referenced this pull request Oct 22, 2020
@chrisronline @lcawl @KOTungseth
[DOCS] Add link for monitoring ssl settings (#81057) (#81327)
bb753d8 
* Add link for ssl settings

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 22, 2020
chrisronline added a commit that referenced this pull request Oct 22, 2020
@chrisronline @lcawl @KOTungseth
[DOCS] Add link for monitoring ssl settings (#81057) (#81328)
7034dbf 
* Add link for ssl settings

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/settings/monitoring-settings.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@chrisronline
Copy link
Contributor Author

Backport:

7.x: bb753d8
7.10: 7034dbf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth left review comments

@igoristic igoristic igoristic approved these changes

@lcawl lcawl lcawl approved these changes

Assignees

@chrisronline chrisronline

Labels
docs release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Kibana Monitoring settings] monitoring.ui.elasticsearch.ssl.certificateAuthorities not documented in 7.9.1
6 participants
@chrisronline @elasticmachine @kibanamachine @lcawl @igoristic @KOTungseth