Fix tagcloud word overlapping #81161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulemanof
added
Feature:Tagcloud
sulemanof
requested review from
DianaDerevyankina,
stratoula,
VladLasitsa and
alexwizp
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
stratoula
reviewed
Oct 21, 2020
| * the fontFamily should be set explicitly for calculating a layout | ||
| * and to avoid words overlapping | ||
| */ | ||
| this._fontFamily = 'Inter UI, sans-serif'; |
There was a problem hiding this comment.
I agree, we can't avoid this, is a known issue on d3-tagcloud
stratoula
approved these changes
Oct 21, 2020
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Oct 21, 2020
* Fix overlaps on resize * Set up font family * Update snapshots
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Oct 21, 2020
* Fix overlaps on resize * Set up font family * Update snapshots
sulemanof
added a commit
that referenced
this pull request
Oct 21, 2020
sulemanof
added a commit
that referenced
this pull request
Oct 21, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 21, 2020
…arm-phase-to-formlib * 'master' of github.com:elastic/kibana: (55 commits) [UX] Fix map color variance and apply proper filter for extended stats (elastic#81106) [User Experience] Use EuiSelect for percentiles instead of SuperSelect (elastic#81082) [DOCS] Add link for monitoring ssl settings (elastic#81057) [test] Await loading indicator in monitoring test (elastic#81279) [ILM] Minor copy and link additions to cloud CTA for cold phase (elastic#80512) [Mappings editor] Add scaled_float and date_range comp integration tests (elastic#81287) [Discover] Deangularize context.app (elastic#80851) [O11y Overview] Add code to display/hide UX section when appropriate (elastic#80873) [Discover] Extend DiscoverNoResults component to show different message on error (elastic#79671) Fix tagcloud word overlapping (elastic#81161) [Security Solution] Fixes flaky test rules (elastic#81040) Changed the code to avoid tech debt with hacky solutions after receiving comments on EUI issue reported about this problem. (elastic#81183) [Security Solution][All] Replace old markdown renderer with the new one (elastic#80301) Add namespaced version of the API call (elastic#81278) [ML] Data Frame Analytics: Fix race condition and support for feature influence legacy format. (elastic#81123) [Fleet] Fix POLICY_CHANGE action creation for new policy (elastic#81236) [Security Solution][Endpoint][Admin] Malware user notification checkbox (elastic#78084) [SecuritySolution][Unit Tests] - fix flakey unit test (elastic#81239) skip flaky suite (elastic#81264) [Maps] fix top-level Map page is called 'Kibana' (elastic#81238) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/forcemerge_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78407
This fixes word overlapping in
tagcloudvisualization when it is resized.The fix returns back the next code, which was omitted in a recent PR - seems it is responsible for additional layout calculations and still needed before resize:
This also changes the
fontFamilytoInter UI.Can't skip setting the
fontFamilyexplicitly (make it inherit), since the setting is necessary for calculating tagcloud layout and word spacing.The final result:
Checklist
Delete any items that are not applicable to this PR.
For maintainers