[Security Solution][Detections] Prevent rules from being created with a blank name or description #82087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our validations were a little lax here. While the fields did not cause any errors as they're still strings, the lack of content causes some UX weirdness that we should prevent. Closes elastic#81319
rylnd
added
v8.0.0
release_note:skip
Adding in the other required fields here to get a more concise error.
|
@elasticmachine merge upstream |
peluja1012
approved these changes
Nov 2, 2020
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
rylnd
added
release_note:fix
and removed
release_note:skip
|
Adding a release note for this; if API users are affected by the new validation they'll have to add a name and description via the API. |
rylnd
added a commit
that referenced
this pull request
Nov 2, 2020
… a blank name or description (#82087) (#82319) * Prevent rules from being created with a blank name or description Our validations were a little lax here. While the fields did not cause any errors as they're still strings, the lack of content causes some UX weirdness that we should prevent. Closes #81319 * Fix unit tests for rule updates Adding in the other required fields here to get a more concise error. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our validations were a little lax here. While the fields did not cause
any errors as they're still strings, the lack of content causes some UX
weirdness that we should prevent.
Closes #81319
Checklist
Delete any items that are not applicable to this PR.
For maintainers