Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Detections] Prevent rules from being created with a blank name or description (#82087) #82319

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Nov 2, 2020

Backports the following commits to 7.x:

… a blank name or description (elastic#82087)

* Prevent rules from being created with a blank name or description

Our validations were a little lax here. While the fields did not cause
any errors as they're still strings, the lack of content causes some UX
weirdness that we should prevent.

Closes elastic#81319

* Fix unit tests for rule updates

Adding in the other required fields here to get a more concise error.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@rylnd rylnd added the backport label Nov 2, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
securitySolution 242.0KB 242.1KB +107.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 3aec8c3 into elastic:7.x Nov 2, 2020
@rylnd rylnd deleted the backport/7.x/pr-82087 branch November 2, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants