-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Unskips Overview tests #82459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@elasticmachine merge upstream |
MadameSheema
added
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v7.11.0
v8.0.0
Team:Threat Hunting
Security Solution Threat Hunting Team
labels
Nov 4, 2020
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
XavierM
approved these changes
Nov 4, 2020
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Nov 5, 2020
* unskips Overview tests * fixes overview tests * unskips 'with no data' test * fixes 'with no data' test * stubs empty instace * fixes typecheck issue * fixes hooks issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
MadameSheema
added a commit
that referenced
this pull request
Nov 5, 2020
* unskips Overview tests * fixes overview tests * unskips 'with no data' test * fixes 'with no data' test * stubs empty instace * fixes typecheck issue * fixes hooks issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 5, 2020
* master: (127 commits) [ILM] Fix breadcrumbs (elastic#82594) [UX]Swap env filter with percentile (elastic#82246) Add platform's missing READMEs (elastic#82268) [Discover] Adding uiMetric to track Visualize link click (elastic#82344) [Search] Add used index pattern name to the search agg error field (elastic#82604) improve client-side SO client get pooling (elastic#82603) [Security Solution] Unskips Overview tests (elastic#82459) Embeddables/migrations (elastic#82296) [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663) Moving reinstall function outside of promise.all (elastic#82672) Load choropleth layer correctly (elastic#82628) Master backport elastic#81233 (elastic#82642) [Fleet] Allow snake cased Kibana assets (elastic#77515) Reduce saved objects authorization checks (elastic#82204) [data.search] Add request handler context and asScoped pattern (elastic#80775) [ML] Fixes formatting of fields in index data visualizer (elastic#82593) Usage collector readme (elastic#82548) [Lens] Visualization validation and better error messages (elastic#81439) [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490) chore(NA): install microdnf in UBI docker build only (elastic#82611) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are fixing and unskipping the Overview Cypress tests.
Overview Page
Failure:
Host stats render with correct values
andNetwork stats render with correct values
on CI execution were returning different number than the expected ones. In local, those tests passed.Problem:
Fix:
overviewHostQuery
call and for the Network events theoverviewNetworkQuery
. In this manner the stub is done properly. The downside of this fix is that we are loading the page two times (originally just one), making the overall execution tests a little bit slow.With no data
Failure:
Problem:
Fix:
/internal/search/securitySolutionIndexFields
call in order to make the UI think that we don't have indexed.