Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Add used index pattern name to the search agg error field #82604

Merged

Conversation

kertal
Copy link
Member

@kertal kertal commented Nov 4, 2020

Summary

This PR improves the search error message adding the name of the index pattern that was used to improve debugging

Bildschirmfoto 2020-11-04 um 14 25 53

Reason for this: Adding a bit more information to debug flakiness in our testing pipeline #81457

@kertal kertal self-assigned this Nov 4, 2020
@kertal kertal added the Feature:Search Querying infrastructure in Kibana label Nov 4, 2020
@kertal kertal marked this pull request as ready for review November 4, 2020 14:25
@kertal kertal requested a review from a team as a code owner November 4, 2020 14:25
@kertal kertal requested a review from lizozom November 4, 2020 14:26
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 4, 2020
@kertal
Copy link
Member Author

kertal commented Nov 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
data 954.7KB 954.8KB +91.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@kertal kertal changed the title Add used index pattern to the search error field [Search] Add used index pattern name to the search error field Nov 5, 2020
@kertal kertal changed the title [Search] Add used index pattern name to the search error field [Search] Add used index pattern name to the search agg error field Nov 5, 2020
@kertal kertal merged commit abc6abc into elastic:master Nov 5, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 5, 2020
* master: (127 commits)
  [ILM] Fix breadcrumbs (elastic#82594)
  [UX]Swap env filter with percentile (elastic#82246)
  Add platform's missing READMEs (elastic#82268)
  [Discover] Adding uiMetric to track Visualize link click (elastic#82344)
  [Search] Add used index pattern name to the search agg error field (elastic#82604)
  improve client-side SO client get pooling (elastic#82603)
  [Security Solution] Unskips Overview tests (elastic#82459)
  Embeddables/migrations (elastic#82296)
  [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663)
  Moving reinstall function outside of promise.all (elastic#82672)
  Load choropleth layer correctly (elastic#82628)
  Master  backport elastic#81233 (elastic#82642)
  [Fleet] Allow snake cased Kibana assets (elastic#77515)
  Reduce saved objects authorization checks (elastic#82204)
  [data.search] Add request handler context and asScoped pattern (elastic#80775)
  [ML] Fixes formatting of fields in index data visualizer (elastic#82593)
  Usage collector readme (elastic#82548)
  [Lens] Visualization validation and better error messages (elastic#81439)
  [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490)
  chore(NA): install microdnf in UBI docker build only (elastic#82611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants