Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uptime overview overhaul #83406

Merged
merged 33 commits into from
Nov 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9256c19
Refactor overview list
shahzad31 Nov 4, 2020
e8dfad2
update snapshots
shahzad31 Nov 4, 2020
c7dea64
update
shahzad31 Nov 4, 2020
5cfd386
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 16, 2020
f69f184
update
shahzad31 Nov 16, 2020
ccde474
Fix monitor list down histogram
shahzad31 Nov 16, 2020
a8d741b
snapshots
shahzad31 Nov 16, 2020
f2c1c09
UP
shahzad31 Nov 16, 2020
118cc48
UP
shahzad31 Nov 16, 2020
797abfb
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 16, 2020
4bd38d2
Merge branch 'fix-monitor-down-histogram' into uptime-overview-overhaul
shahzad31 Nov 16, 2020
073b2a4
fix type
shahzad31 Nov 16, 2020
88f9a12
Snapshots
shahzad31 Nov 16, 2020
417b0a4
fix tests
shahzad31 Nov 16, 2020
88c62a2
update i18n
shahzad31 Nov 16, 2020
6145462
fix type
shahzad31 Nov 16, 2020
dd2a31c
fix test
shahzad31 Nov 16, 2020
4b35924
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 17, 2020
4f11724
PR feedback
shahzad31 Nov 17, 2020
343532c
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 17, 2020
c56318a
PR feedback
shahzad31 Nov 17, 2020
539b280
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 18, 2020
b6b1f20
center align status badge
shahzad31 Nov 18, 2020
5d1deae
fix types
shahzad31 Nov 18, 2020
9ace208
Merge branch 'master' into uptime-overview-overhaul
kibanamachine Nov 23, 2020
3f30a6b
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 25, 2020
a6b7a47
fix table exapnd arrow alignment
shahzad31 Nov 25, 2020
9278338
update snaps
shahzad31 Nov 25, 2020
d49910a
Merge branch 'uptime-overview-overhaul' of https://github.com/shahzad…
shahzad31 Nov 25, 2020
d6e1931
Merge branch 'master' into uptime-overview-overhaul
shahzad31 Nov 26, 2020
9acf417
PR feedback
shahzad31 Nov 26, 2020
825535b
update snaps
shahzad31 Nov 26, 2020
583eb4f
Merge branch 'master' into uptime-overview-overhaul
kibanamachine Nov 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -20634,11 +20634,8 @@
"xpack.uptime.monitorList.defineConnector.description": "アラートを有効にするには、デフォルトのアラートアクションコネクターを定義してください。",
"xpack.uptime.monitorList.disableDownAlert": "ステータスアラートを無効にする",
"xpack.uptime.monitorList.downLineSeries.downLabel": "ダウン",
"xpack.uptime.monitorList.drawer.locations.statusDown": "{locations}でダウン",
"xpack.uptime.monitorList.drawer.locations.statusUp": "{locations}でアップ",
"xpack.uptime.monitorList.drawer.missingLocation": "一部のHeartbeatインスタンスには位置情報が定義されていません。Heartbeat構成への{link}。",
"xpack.uptime.monitorList.enabledAlerts.noAlert": "このモニターではアラートが有効ではありません。",
"xpack.uptime.monitorList.enabledAlerts.title": "有効なアラート:",
"xpack.uptime.monitorList.enableDownAlert": "ステータスアラートを有効にする",
"xpack.uptime.monitorList.expandDrawerButton.ariaLabel": "ID {id}のモニターの行を展開",
"xpack.uptime.monitorList.geoName.helpLinkAnnotation": "場所を追加",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -20654,11 +20654,8 @@
"xpack.uptime.monitorList.defineConnector.description": "要开始启用告警,请在以下位置定义默认告警操作连接器",
"xpack.uptime.monitorList.disableDownAlert": "禁用状态告警",
"xpack.uptime.monitorList.downLineSeries.downLabel": "关闭",
"xpack.uptime.monitorList.drawer.locations.statusDown": "在 {locations} 已关闭",
"xpack.uptime.monitorList.drawer.locations.statusUp": "在 {locations} 正运行",
"xpack.uptime.monitorList.drawer.missingLocation": "某些 Heartbeat 实例未定义位置。{link}到您的 Heartbeat 配置。",
"xpack.uptime.monitorList.enabledAlerts.noAlert": "没有为此监测启用告警。",
"xpack.uptime.monitorList.enabledAlerts.title": "已启用的告警:",
"xpack.uptime.monitorList.enableDownAlert": "启用状态告警",
"xpack.uptime.monitorList.expandDrawerButton.ariaLabel": "展开 ID {id} 的监测行",
"xpack.uptime.monitorList.geoName.helpLinkAnnotation": "添加位置",
Expand Down
11 changes: 8 additions & 3 deletions x-pack/plugins/uptime/common/runtime_types/monitor/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,14 @@ export const StateType = t.intersection([
up: t.number,
down: t.number,
}),
monitor: t.partial({
name: t.string,
}),
monitor: t.intersection([
t.partial({
name: t.string,
}),
t.type({
type: t.string,
}),
]),
}),
t.partial({
tls: t.partial({
Expand Down
40 changes: 22 additions & 18 deletions x-pack/plugins/uptime/public/apps/uptime_app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ import {
import { store } from '../state';
import { kibanaService } from '../state/kibana_service';
import { ScopedHistory } from '../../../../../src/core/public';
import { EuiThemeProvider } from '../../../observability/public';

export interface UptimeAppColors {
danger: string;
dangerBehindText: string;
success: string;
gray: string;
range: string;
Expand Down Expand Up @@ -103,24 +105,26 @@ const Application = (props: UptimeAppProps) => {
services={{ ...core, ...plugins, triggersActionsUi: startPlugins.triggersActionsUi }}
>
<Router history={props.history}>
<UptimeRefreshContextProvider>
<UptimeSettingsContextProvider {...props}>
<UptimeThemeContextProvider darkMode={darkMode}>
<UptimeStartupPluginsContextProvider {...startPlugins}>
<UptimeAlertsContextProvider>
<EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp">
<RedirectAppLinks application={core.application}>
<main>
<UptimeAlertsFlyoutWrapper />
<PageRouter />
</main>
</RedirectAppLinks>
</EuiPage>
</UptimeAlertsContextProvider>
</UptimeStartupPluginsContextProvider>
</UptimeThemeContextProvider>
</UptimeSettingsContextProvider>
</UptimeRefreshContextProvider>
<EuiThemeProvider darkMode={darkMode}>
<UptimeRefreshContextProvider>
<UptimeSettingsContextProvider {...props}>
<UptimeThemeContextProvider darkMode={darkMode}>
<UptimeStartupPluginsContextProvider {...startPlugins}>
<UptimeAlertsContextProvider>
<EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp">
<RedirectAppLinks application={core.application}>
<main>
<UptimeAlertsFlyoutWrapper />
<PageRouter />
</main>
</RedirectAppLinks>
</EuiPage>
</UptimeAlertsContextProvider>
</UptimeStartupPluginsContextProvider>
</UptimeThemeContextProvider>
</UptimeSettingsContextProvider>
</UptimeRefreshContextProvider>
</EuiThemeProvider>
</Router>
</KibanaContextProvider>
</ReduxProvider>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
import { Tls, X509Expiry } from '../../../../../common/runtime_types';
import { CERTIFICATES_ROUTE } from '../../../../../common/constants';
import { MonListDescription, MonListTitle } from './status_bar';
import { CertStatusColumn } from '../../../overview/monitor_list/cert_status_column';
import { CertStatusColumn } from '../../../overview/monitor_list/columns/cert_status_column';

interface Props {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export const FilterPopover = ({
const mItems = selectedItems.concat(allItems ?? []);
const newItems = mItems.filter((item, index) => mItems.indexOf(item) === index);
setItems(newItems);
setTempSelectedItems(selectedItems);
}, [allItems, selectedItems]);

useEffect(() => {
Expand All @@ -73,7 +74,7 @@ export const FilterPopover = ({
isDisabled={disabled && selectedItems.length === 0}
isSelected={tempSelectedItems.length > 0}
numFilters={items.length}
numActiveFilters={tempSelectedItems.length}
numActiveFilters={isOpen ? tempSelectedItems.length : selectedItems.length}
onClick={() => {
setIsOpen(!isOpen);
onFilterFieldChange(fieldName, tempSelectedItems);
Expand Down
Loading