Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptime overview overhaul #83406

Merged
merged 33 commits into from
Nov 30, 2020
Merged

Uptime overview overhaul #83406

merged 33 commits into from
Nov 30, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 16, 2020 •
edited
Loading

Summary

Uptime overview overhaul

image

Resolves: #80133

@shahzad31 shahzad31 marked this pull request as ready for review November 16, 2020 15:50
@shahzad31 shahzad31 requested a review from a team as a code owner November 16, 2020 15:50
@shahzad31 shahzad31 self-assigned this Nov 16, 2020
@shahzad31 shahzad31 requested a review from Kerry350 November 16, 2020 15:51
@apmmachine
Copy link
Contributor

💚 Build Succeeded

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

katrin-freihofner
katrin-freihofner approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments below

x-pack/plugins/uptime/public/components/overview/monitor_list/columns/monitor_status_column.tsx Outdated Show resolved Hide resolved
...ns/uptime/public/components/overview/monitor_list/monitor_list_drawer/monitor_status_row.tsx Outdated Show resolved Hide resolved
katrin-freihofner
katrin-freihofner suggested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me clicking a 100 times - please ignore this

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@katrin-freihofner
Copy link
Contributor

Looks good. Only the tables' expand arrow on smaller screens is not centered
Screenshot 2020-11-23 at 16 06 46

@katrin-freihofner
Copy link
Contributor

Screenshot 2020-11-23 at 16 05 50

I also found this issue with the two icons but I don't think that this is related to the PR. 🤔

@paulb-elastic
Copy link
Contributor

To ensure a consistent look and feel (e.g. consistent badges across the UI), don't merge until #80144 and #80156 are also ready.

@EamonnTP EamonnTP mentioned this pull request Nov 24, 2020
Closed
@Kerry350
Copy link
Contributor

I'll review the code today, sorry for the delay.

Kerry350
Kerry350 approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I left a few comments but nothing blocking.

x-pack/plugins/uptime/public/components/overview/monitor_list/columns/filter_label.tsx Outdated Show resolved Hide resolved
x-pack/plugins/uptime/public/components/overview/monitor_list/columns/monitor_status_column.tsx Outdated Show resolved Hide resolved
...lugins/uptime/public/components/overview/monitor_list/monitor_list_drawer/enabled_alerts.tsx Show resolved Hide resolved
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 528 531 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 985.0KB 995.0KB +9.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 2e6dca6 into elastic:master Nov 30, 2020
@shahzad31 shahzad31 deleted the uptime-overview-overhaul branch November 30, 2020 12:51
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Nov 30, 2020
@shahzad31 @kibanamachine
Uptime overview overhaul (elastic#83406)
7efeeaf 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@shahzad31 shahzad31 mentioned this pull request Nov 30, 2020
Merged
shahzad31 added a commit that referenced this pull request Nov 30, 2020
@shahzad31 @kibanamachine
[7.x] Uptime overview overhaul (#83406) (#84501)
8ca2ab1 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
@phillipb
Merge branch 'add-metadata-to-node-details' of github.com:phillipb/ki…
6a491e8 
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 30, 2020
@gmmorris
Merge branch 'master' into alerts/rename-resolved-to-recovered
e066f65 
* master: (25 commits)
  [Alerting] fixes buggy default message behaviour (elastic#84202)
  [Graph] Use new ES client and change license API (elastic#84398)
  [DOCS] Adds redirect to known plugins page (elastic#84001)
  Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376)
  Adding timestamps to created events so the sorting is stable (elastic#84515)
  [DOCS] Redirects for drilldown links (elastic#83846)
  [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805)
  [Enterprise Search] Migrate shared Schema components (elastic#84381)
  [Discover] Unskip date_nanos and shard links functional tests (elastic#82878)
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katrin-freihofner katrin-freihofner katrin-freihofner approved these changes

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime UI] Update Uptime overview to support synthetic checks
7 participants
@shahzad31 @apmmachine @elasticmachine @Kerry350 @katrin-freihofner @paulb-elastic @kibanamachine