Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Adds visConfig.title and uiState to build pipeline function #84456

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

fbaligand
Copy link
Contributor

@fbaligand fbaligand commented Nov 27, 2020

In pipeline building, this PR adds visConfig.title and uiState properties for "visualization" function.

This aims 2 goals:

  • To be consistent with pipelines built with "buildPipelineVisFunction".
  • To provide "title" and "uiState" informations for visualizations.

This is currently a missing information for community plugins.

- To be consistent with visualizations built with "buildPipelineVisFunction".
- To provide "title" information for visualizations.
@fbaligand fbaligand requested a review from a team November 27, 2020 22:28
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@fbaligand fbaligand changed the title add visConfig.title to pipeline visualization function add visConfig.title and uiState to pipeline visualization function Nov 28, 2020
@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@stratoula
Copy link
Contributor

Jenkins, test this

@stratoula stratoula self-assigned this Nov 30, 2020
@stratoula stratoula added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 30, 2020
@stratoula stratoula changed the title add visConfig.title and uiState to pipeline visualization function [Visualizations] Adds visConfig.title and uiState to build pipeline function Nov 30, 2020
@stratoula stratoula added v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 169.0KB 169.1KB +70.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @fbaligand for this PR! Code LGTM 🍪

@stratoula stratoula merged commit d11ca6c into elastic:master Nov 30, 2020
stratoula pushed a commit to stratoula/kibana that referenced this pull request Nov 30, 2020
…unction (elastic#84456)

* add visConfig.title to pipeline visualization function

- To be consistent with visualizations built with "buildPipelineVisFunction".
- To provide "title" information for visualizations.

* add uiState to pipeline visualization function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@fbaligand
Copy link
Contributor Author

Thanks a lot @stratoula!

@fbaligand fbaligand deleted the patch-10 branch November 30, 2020 12:35
stratoula added a commit that referenced this pull request Nov 30, 2020
…unction (#84456) (#84488)

* add visConfig.title to pipeline visualization function

- To be consistent with visualizations built with "buildPipelineVisFunction".
- To provide "title" information for visualizations.

* add uiState to pipeline visualization function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Fabien Baligand <fbaligand@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 30, 2020
…bana into add-metadata-to-node-details

* 'add-metadata-to-node-details' of github.com:phillipb/kibana:
  [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended  (elastic#84415)
  Support for painless language autocomplete within monaco (elastic#80577)
  [Lens] Time scale ui (elastic#83904)
  removing beta callouts (elastic#84510)
  [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493)
  Trusted Apps signer API. (elastic#83661)
  increase stdout max listeners for legacy logging (elastic#84497)
  [APM] Service overview: Add throughput chart (elastic#84439)
  [Discover] Unskip main functional tests (elastic#84300)
  Uptime overview overhaul (elastic#83406)
  [APM] Adjust time formats based on the difference between start and end (elastic#84470)
  [ML] Renaming saved object repair to sync (elastic#84311)
  [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313)
  [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456)
  [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322)
  TSVB field list performance issue on using annotations (elastic#84407)
  [Security Solution] Exceptions Cypress tests (elastic#81759)
  [ML] Fix spaces job ID check (elastic#84404)
  [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💝community Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants