-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualizations] Adds visConfig.title and uiState to build pipeline function #2192
Conversation
Hey @fbaligand can you open an issue to discuss your usecase and how you intend on using this additional information to build community plugins? The change looks good to me, but i will need to make sure that it does not break anything since the visualization renderer cant handle a changing UIState and adding this might cause issues with that. |
Codecov Report
@@ Coverage Diff @@
## main #2192 +/- ##
==========================================
- Coverage 67.23% 67.22% -0.01%
==========================================
Files 3100 3100
Lines 59566 59567 +1
Branches 9063 9063
==========================================
- Hits 40047 40043 -4
- Misses 17332 17336 +4
- Partials 2187 2188 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @ashwin-pc, actually, I need this fix so that community plugins (like mine: https://github.com/fbaligand/kibana-enhanced-table) can do "CSV export" with filename "[visualization name].csv" (instead of "export.csv"). And especially, I have done exactly the same PR on Elastic Kibana, that has been merged in 2020 for Kibana 7.11: Actually, this is a bug fix, because, in previous Kibana versions (7.7 and earlier), "CSV export" was already saved as "[visualization name].csv". |
@fbaligand Thanks for the context! I agree with the change, it was just backwards compatibility that had me a little concerned, specifically with |
…unction In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com>
…unction (#2192) In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: fbaligand <fbaligand@gmail.com> (cherry picked from commit 140c56f)
Thanks for having merged the PR! |
…unction (#2192) In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: fbaligand <fbaligand@gmail.com> (cherry picked from commit 140c56f)
…unction (#2192) (#2272) In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: fbaligand <fbaligand@gmail.com> (cherry picked from commit 140c56f) Co-authored-by: Fabien Baligand <fbaligand@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
…unction (opensearch-project#2192) In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
…unction (opensearch-project#2192) In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function. This aims 2 goals: - To be consistent with pipelines built with "buildPipelineVisFunction". - To provide "title" and "uiState" informations for visualizations. This is currently a missing information for community plugins. Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: fbaligand <fbaligand@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
In pipeline building, this PR adds
visConfig.title
anduiState
properties for "visualization" function.This aims 2 goals:
This is currently a missing information for community plugins.